Use rand() instead of QRandomGenerator for performance reasons#5
Open
drpeterfranz wants to merge 1 commit intosandsmark:masterfrom
Open
Use rand() instead of QRandomGenerator for performance reasons#5drpeterfranz wants to merge 1 commit intosandsmark:masterfrom
drpeterfranz wants to merge 1 commit intosandsmark:masterfrom
Conversation
Author
|
@sandsmark can you please have a look why the pipeline fails? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tests I found that QRandomGenerator took ages (literally minutes) to generate random numbers for the test binary data. Using rand() instead decreases this time to non-noticable. Since no high-quality random numbers are required for the testing purposes the choice of rand() should be justified.