feat(parser): add support for parsing custom functions #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
force-pushed
the
feat/support-custom-fn
branch
from
8a41eb4 to
54a5abf
Compare
sgulseth
commented
Oct 23, 2025
| } | ||
| const processor = new MarkProcessor(input, result.marks, options) | ||
| return processor.process(EXPR_BUILDER) | ||
| validateCustomFunctions(input, result.customFunctions) |
Member
Author
There was a problem hiding this comment.
This one ensures that we also validate unused functions
sgulseth
force-pushed
the
feat/support-custom-fn
branch
from
54a5abf to
e4efda3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #308
Adds support for parsing custom functions by using marks to replace during parsing. Replaces all the custom function definition during mark processing
What to review
Testing
Added som basic tests to the parser, and enabled custom functions tests from the groq test suite