feat(access): if a project user can't be found envoke dashboard request-access flow #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
joshuaellis
force-pushed
the
feat/DASH-947
branch
from
c420e7c to
accd846
Compare
joshuaellis
force-pushed
the
feat/DASH-947
branch
from
accd846 to
9aeb136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #651 we added a nice fallback for if the project user couldn't be found, with the addition of https://github.com/sanity-io/ada/pull/2013 any app can summon the request access flow for a particular few type of resources. Currently quite restricted i've not made a dedicated hook for users to consume yet but inlined the work as a POC.
What to review
useWindowConnectionhook in theLoginErrorokay? my understanding is that the hook will suspend the app until a connection is found...Testing
Fun gif