fix(e2e): ensure tests run in dashboard and correct org when not in CI #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cngonzalez
force-pushed
the
fix/update-e2e-tests-for-running-dashboard
branch
from
f446f6f to
f9dba71
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we moved to running Kitchensink in Dashboard, the old way of running tests
pnpm dev --mode e2ewould not correctly parse, and not correctly signify to the Kitchensink config that it should use the e2e project / organization specified. This PR corrects that.This PR also consolidates our tests. Since we try to always run Kitchensink in Dashboard, there wasn't much sense in having standalone projects anymore.
However, one project has to remain standalone -- testing in Safari (because of technical limitations).
To help devs a little bit, new commands were created to help them from having to run every single project individually.
Anyway everyone can rejoice because now there's only 3 e2e test suites in CI rather than 4.
What to review
Any gotchas? Any of these choices tedious?
Testing
Yes.
Fun gif