refactor(plan) Extract and refactor generic plan utils #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/lib/utils/object.ts
# Conflicts: # src/lib/ui/app/PaymentForm/flow.ts # src/lib/ui/app/SubscriptionPlan/PlanButton.svelte # src/lib/ui/app/SubscriptionPlan/plans.ts # src/lib/ui/app/SubscriptionPlan/utils.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionPlan->PlanandgetPlanName->getPlanDisplayNamePlannow is enum-like object with key same as valuecheckIsBusinessPlanandcheckIsConsumerPlannow accepts raw plan name instead of objectBUSINESS_PLANSandCONSUMER_PLANSsets are now NOT exposed. (usecheckIsBusinessPlanandcheckIsConsumerPlaninstead). Can it lead to any problems?getProductPlansnow acceptsplanCheckerfunction instead of set of plansisPlanEligibleForhelper is added and used ingetCustomerSubscriptionDatafunction. NOTE: There are slight logical changes in computingisProand similar flags, but now they are more logicalCUSTOMasCUSTOMNotion card
https://www.notion.so/santiment/Finish-user-profile-page-with-new-data-1e02a82d13618079afbce9cdf0aac4b3?source=copy_link