Skip to content

archer f5os improve deletion #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
notandy wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

archer f5os improve deletion #608

notandy wants to merge 2 commits into from

Conversation

@notandy
Copy link
Collaborator

@notandy notandy commented Jul 15, 2025

  • [f5os] use DELETE instead of PUT to reduce roundtrips

@notandy notandy force-pushed the archer-f5os-improve-deletion branch from 5848bcd to 4a2c08b Compare July 15, 2025 22:57
@coveralls
Copy link

coveralls commented Jul 15, 2025

Pull Request Test Coverage Report for Build 16306130398

Details

  • 1 of 15 (6.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 20.888%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/agent/f5/f5os/f5os.go 1 15 6.67%
Totals Coverage Status
Change from base Build 16306062425: 0.009%
Covered Lines: 2418
Relevant Lines: 11576
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronchi-oss ronchi-oss Awaiting requested review from ronchi-oss ronchi-oss will be requested when the pull request is marked ready for review ronchi-oss is a code owner

@notque notque Awaiting requested review from notque notque will be requested when the pull request is marked ready for review notque is a code owner

@m-kratochvil m-kratochvil Awaiting requested review from m-kratochvil m-kratochvil will be requested when the pull request is marked ready for review m-kratochvil is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@notandy @coveralls @notque