Skip to content

fix: go versions different across docker targets #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asergeant01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: go versions different across docker targets #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
#
# SPDX-License-Identifier: Apache-2.0

ARG TARGET_GO_VERSION=1.25.1

# Build the manager binary
FROM --platform=$BUILDPLATFORM golang:1.25.1 AS builder
FROM --platform=$BUILDPLATFORM golang:${TARGET_GO_VERSION} AS builder
ARG TARGETOS TARGETARCH
ARG BININFO_BUILD_DATE BININFO_COMMIT_HASH BININFO_VERSION

Expand Down Expand Up @@ -33,7 +35,7 @@ RUN --mount=type=cache,target=/root/.cache/go-build \


# Debug image (with Delve, non-distroless)
FROM --platform=$BUILDPLATFORM golang:1.24.4 AS debug
FROM --platform=$BUILDPLATFORM golang:${TARGET_GO_VERSION} AS debug
ARG BININFO_BUILD_DATE BININFO_COMMIT_HASH BININFO_VERSION
LABEL source_repository="https://github.com/sapcc/argora" \
org.opencontainers.image.url="https://github.com/sapcc/argora" \
Expand Down
3 changes: 2 additions & 1 deletion Tiltfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ if target == 'debug':
'controller:latest',
'.',
target=target,
entrypoint='dlv exec /manager --headless --listen=:3000 --accept-multiclient --continue --',
# Forward all container args (including the first, which is $0 under sh -c) to the manager
entrypoint='set -- "$0" "$@"; exec dlv exec /manager --headless --listen=:3000 --accept-multiclient --continue -- "$@"',
build_args=build_args
)
else:
Expand Down
Loading