Skip to content

Conversation

@defo89
Copy link
Member

@defo89 defo89 commented Dec 24, 2025

This adds CR and controller to import Cluster-API IPAM GlobalInClusterIPPools from Netbox based on Region and Role.

@defo89 defo89 marked this pull request as draft December 24, 2025 16:14
@defo89 defo89 force-pushed the ippools branch 4 times, most recently from 50cfbfc to 239aafd Compare December 25, 2025 15:29
@defo89 defo89 marked this pull request as ready for review December 25, 2025 16:26
@github-actions
Copy link

Merging this branch changes the coverage (2 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/sapcc/argora/api/v1alpha1 26.57% (-12.28%) 💀
github.com/sapcc/argora/cmd/manager 0.00% (ø)
github.com/sapcc/argora/internal/controller 79.02% (-1.75%) 👎
github.com/sapcc/argora/internal/controller/mock 79.63% (+0.78%) 👍
github.com/sapcc/argora/internal/netbox 77.27% (ø)
github.com/sapcc/argora/internal/netbox/ipam 95.96% (+0.90%) 👍
github.com/sapcc/argora/internal/status 87.93% (+0.43%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/argora/api/v1alpha1/common.go 0.00% (ø) 0 0 0
github.com/sapcc/argora/api/v1alpha1/conditions.go 72.73% (ø) 11 8 3
github.com/sapcc/argora/api/v1alpha1/ippoolimport_types.go 100.00% (+100.00%) 1 (+1) 1 (+1) 0 🌟
github.com/sapcc/argora/api/v1alpha1/zz_generated.deepcopy.go 22.80% (-12.12%) 193 (+67) 44 149 (+67) 💀
github.com/sapcc/argora/cmd/manager/main.go 0.00% (ø) 0 0 0
github.com/sapcc/argora/internal/controller/ippoolimport_controller.go 70.11% (+70.11%) 87 (+87) 61 (+61) 26 (+26) 🌟
github.com/sapcc/argora/internal/controller/mock/mock.go 79.63% (+0.78%) 54 (+2) 43 (+2) 11 👍
github.com/sapcc/argora/internal/netbox/ipam/ipam.go 92.16% (+1.46%) 51 (+8) 47 (+8) 4 👍
github.com/sapcc/argora/internal/netbox/ipam/ipam_requests.go 100.00% (ø) 48 (+10) 48 (+10) 0
github.com/sapcc/argora/internal/status/status.go 87.93% (+0.43%) 58 (+18) 51 (+16) 7 (+2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/argora/internal/controller/ippoolimport_controller_test.go
  • github.com/sapcc/argora/internal/controller/suite_test.go
  • github.com/sapcc/argora/internal/controller/update_controller_test.go
  • github.com/sapcc/argora/internal/netbox/ipam/ipam_test.go
  • github.com/sapcc/argora/internal/netbox/netbox_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants