Skip to content

Cosmetic changes#71

Draft
CodeFetch wants to merge 7 commits intosargon:masterfrom
freifunkh:pr_cleanup
Draft

Cosmetic changes#71
CodeFetch wants to merge 7 commits intosargon:masterfrom
freifunkh:pr_cleanup

Conversation

@CodeFetch
Copy link
Copy Markdown

I'd like to propose a few style changes like:

  • using imperative form for comments describing an action
  • using tabs for indentation instead of spaces
  • defining variables at the beginning of a function
  • global includes first
  • dropping curly braces of for/if-constructions with a single command
  • requiring basic C knowledge from the reader like int == 0/pointer == NULL equals !int/!pointer

This commit changes the code style to one similar to the Linux
kernel code style as there were many inconsistencies.
It is more obvious in which file the functions are defined if
they use the file name as a basis for their names.
This commit adds a SPDX identifier to all C and header files and
a short file-specific description.
Because they look better.
@CodeFetch CodeFetch marked this pull request as draft January 27, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant