feat: add optional DataFog redaction for RunRecorder#19
Draft
sidmohan0 wants to merge 2 commits intosauravvenkat:mainfrom
Draft
feat: add optional DataFog redaction for RunRecorder#19sidmohan0 wants to merge 2 commits intosauravvenkat:mainfrom
sidmohan0 wants to merge 2 commits intosauravvenkat:mainfrom
Conversation
Author
|
hey @sauravvenkat kept it opt-in but lmk if you'd prefer it handled a different way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional, backward-compatible DataFog integration to Forkline’s
RunRecorderstorage redaction boundary (recorder path only).Why this PR
RedactionPolicybehavior and deterministic redaction.What changed
Code
forkline/storage/recorder.pyenable_datafog: bool = Falsedatafog_mode: str = "redact"datafog_entity_types: Optional[list[str]] = Noneredaction_policy.redact(...)when enabled.forkline/storage/datafog_adapter.py(new)tests/unit/test_redaction_policy.pyTestRecorderIntegration::test_recorder_applies_datafog_when_enabled.Backward compatibility
enable_datafog=False.Validation
python -m black --check .python -m ruff check .python -m unittest discover -s testsResults (on this branch)
Ran 188 tests in 0.331s✅Implementation details
RunRecorderonly (not tracer path) for PR scope and safety.Follow-up (optional)
SQLiteStorepath if required by downstream consumers.