Skip to content

Fix non-string types like bool / int being saved as string in outputs.jsonl #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junya-takayama wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −9
Open

Fix non-string types like bool / int being saved as string in outputs.jsonl #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de4b1f3
fix _truncate_base64
junya-takayama Apr 2, 2026
7b3210e
format
junya-takayama Apr 2, 2026
f12bf17
fix type annotation
junya-takayama Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flexeval/core/utils/json_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ def _truncate_base64(o: Any) -> Any: # noqa: ANN401
return type(o)(_truncate_base64(item) for item in o)
if isinstance(o, dict):
return {k: _truncate_base64(v) for k, v in o.items()}
if isinstance(o, (int, float, bool, type(None))):
return o

s = str(o)

Expand Down
26 changes: 17 additions & 9 deletions tests/core/utils/test_json_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import dataclasses
import json
from ast import literal_eval

import pytest

from flexeval.core.utils.json_util import Base64TruncatingJSONEncoder


@dataclasses.dataclass
class TestDataClass:
field1: str
field2: int
field2: int | float | bool | None


class TestData:
Expand All @@ -27,25 +28,32 @@ def test_truncate_base64() -> None:
def _json_dumps(x): # noqa: ANN001, ANN202
return json.dumps(x, cls=Base64TruncatingJSONEncoder)

assert literal_eval(_json_dumps(TestDataClass("example", 123))) == {"field1": "example", "field2": "123"}
assert json.loads(_json_dumps(TestDataClass("example", 123))) == {"field1": "example", "field2": 123}

assert json.loads(_json_dumps(TestDataClass("example", 1.23))) == pytest.approx(
{"field1": "example", "field2": 1.23}
)

assert json.loads(_json_dumps(TestDataClass("example", True))) == {"field1": "example", "field2": True}
assert json.loads(_json_dumps(TestDataClass("example", None))) == {"field1": "example", "field2": None}
Comment on lines +37 to +38
Copy link
Copy Markdown
Collaborator Author

@junya-takayama junya-takayama Apr 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because errors occur due to the difference between Python’s bool/None literals (True / False / None ) and JSON boolean/null literals ( true / false / none ), I’m replacing literal_eval() with json.loads().


assert literal_eval(_json_dumps(TestData())) == "TestData"
assert json.loads(_json_dumps(TestData())) == "TestData"

assert literal_eval(_json_dumps({"key": base64_string})) == {
assert json.loads(_json_dumps({"key": base64_string})) == {
"key": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAgA/... [truncated, 169 chars total]"
}

assert literal_eval(_json_dumps([base64_string, "normal string"])) == [
assert json.loads(_json_dumps([base64_string, "normal string"])) == [
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAgA/... [truncated, 169 chars total]",
"normal string",
]

assert literal_eval(_json_dumps(TestDataClass(base64_string, 456))) == {
assert json.loads(_json_dumps(TestDataClass(base64_string, 456))) == {
"field1": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAgA/... [truncated, 169 chars total]",
"field2": "456",
"field2": 456,
}

image_url = literal_eval(
image_url = json.loads(
_json_dumps({"messages": [{"content": {"type": "image_url", "image_url": {"url": base64_string}}}]})
)
assert (
Expand Down
Loading