Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Versioning pickles #204

Open
heathermiller wants to merge 1 commit into
base: 0.9.x
Choose a base branch
from
Open

Versioning pickles #204

heathermiller wants to merge 1 commit into from

Conversation

@heathermiller
Copy link
Member

@heathermiller heathermiller commented Oct 13, 2014

No description provided.

@heathermiller
Copy link
Member Author

heathermiller commented Oct 13, 2014

This is open for discussion. Also FYI @dzufferey (we're touching the pickle format here)

phaller
phaller reviewed Oct 13, 2014
View reviewed changes
core/src/main/scala/pickling/binary/BinaryPickleFormat.scala
Copy link
Contributor

@phaller phaller Oct 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throw PicklingException instead?

@heathermiller heathermiller self-assigned this Oct 13, 2014
@phaller phaller added this to the 0.10.0 Final milestone Oct 23, 2014
@heathermiller
Copy link
Member Author

heathermiller commented Nov 3, 2014

Note to self: repoint at 0.10.0

@heathermiller
Copy link
Member Author

heathermiller commented Nov 4, 2014

For some reason this segfaults for me locally...

jsuereth
jsuereth reviewed Jan 20, 2015
View reviewed changes
core/src/main/scala/pickling/PBuilderReader.scala
Copy link
Contributor

@jsuereth jsuereth Jan 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no endPickle?

@eed3si9n eed3si9n removed this from the 0.10.0 Final milestone Feb 6, 2015
@jasonalaw
Copy link

jasonalaw commented Apr 16, 2015

@heathermiller I saw this pull request and got very excited. Is this an answer to schema evolution with Scala Pickling? I'm very intrigued by Scala Pickling, but I can't jump in until I have some way to evolve my pickled and persisted data structures.

@eed3si9n
Copy link
Member

eed3si9n commented Aug 11, 2015

We should look into implementing versioning on 0.11 branch.

@heathermiller
Copy link
Member Author

heathermiller commented Aug 12, 2015

Agreed. Although one thing that's happening here is that people are merging the idea of serialization with schema evolution... I'm not sure these concepts should be merged into one. It requires a pretty fundamental design rethink.

@jsuereth
Copy link
Contributor

jsuereth commented Aug 12, 2015

+1. I think pickling (serialization) shoudl enable schema and schema evolution. NOT be the schema/schema evolution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@heathermiller heathermiller

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@heathermiller @jasonalaw @eed3si9n @jsuereth @phaller