Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 2 additions & 174 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,177 +168,6 @@ jobs:
run: sbt ";scala3-bootstrapped-new/compile ;scala3-compiler-bootstrapped-new/test"
shell: cmd

community_build_a:
runs-on: [self-hosted, Linux]
container:
image: lampepfl/dotty:2024-10-18
options: --cpu-shares 4096
volumes:
- ${{ github.workspace }}/../../cache/sbt:/root/.sbt
- ${{ github.workspace }}/../../cache/ivy:/root/.ivy2/cache
- ${{ github.workspace }}/../../cache/general:/root/.cache
if: "github.event_name == 'schedule' && github.repository == 'scala/scala3'
|| github.event_name == 'push'
|| github.event_name == 'merge_group'
|| (
github.event_name == 'pull_request'
&& !contains(github.event.pull_request.body, '[skip ci]')
&& !contains(github.event.pull_request.body, '[skip community_build]')
&& !contains(github.event.pull_request.body, '[skip community_build_a]')
)
|| (
github.event_name == 'workflow_dispatch'
&& github.repository == 'scala/scala3'
)"

steps:
##############################################################################################
## WARNING: DO NOT CHANGE THE JAVA VERSION HERE. SCALA 3.8.0+ IS DISTRIBUTED USING JAVA 17. ##
##############################################################################################
- name: Set JDK 17 as default
run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH
- name: Reset existing repo
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git -c "http.https://github.com/.extraheader=" fetch --recurse-submodules=no "https://github.com/scala/scala3" && git reset --hard FETCH_HEAD || true

- name: Checkout cleanup script
uses: actions/checkout@v5

- name: Cleanup
run: .github/workflows/cleanup.sh

- name: Git Checkout
uses: actions/checkout@v5

- name: Add SBT proxy repositories
run: cp -vf .github/workflows/repositories /root/.sbt/ ; true

- name: Test
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git submodule sync
git submodule update --init --recursive --jobs 7
./project/scripts/sbt "community-build/testOnly dotty.communitybuild.CommunityBuildTestA"

- name: Show dependency tracking file
if: ${{ always() }}
run: cat community-build/dotty-community-build-deps || true

community_build_b:
runs-on: [self-hosted, Linux]
container:
image: lampepfl/dotty:2024-10-18
options: --cpu-shares 4096
volumes:
- ${{ github.workspace }}/../../cache/sbt:/root/.sbt
- ${{ github.workspace }}/../../cache/ivy:/root/.ivy2/cache
- ${{ github.workspace }}/../../cache/general:/root/.cache
if: "github.event_name == 'schedule' && github.repository == 'scala/scala3'
|| github.event_name == 'push'
|| github.event_name == 'merge_group'
|| (
github.event_name == 'pull_request'
&& !contains(github.event.pull_request.body, '[skip ci]')
&& !contains(github.event.pull_request.body, '[skip community_build]')
&& !contains(github.event.pull_request.body, '[skip community_build_b]')
)
|| (
github.event_name == 'workflow_dispatch'
&& github.repository == 'scala/scala3'
)"

steps:
##############################################################################################
## WARNING: DO NOT CHANGE THE JAVA VERSION HERE. SCALA 3.8.0+ IS DISTRIBUTED USING JAVA 17. ##
##############################################################################################
- name: Set JDK 17 as default
run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH
- name: Reset existing repo
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git -c "http.https://github.com/.extraheader=" fetch --recurse-submodules=no "https://github.com/scala/scala3" && git reset --hard FETCH_HEAD || true

- name: Checkout cleanup script
uses: actions/checkout@v5

- name: Cleanup
run: .github/workflows/cleanup.sh

- name: Git Checkout
uses: actions/checkout@v5

- name: Add SBT proxy repositories
run: cp -vf .github/workflows/repositories /root/.sbt/ ; true

- name: Test
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git submodule sync
git submodule update --init --recursive --jobs 7
./project/scripts/sbt "community-build/testOnly dotty.communitybuild.CommunityBuildTestB"

- name: Show dependency tracking file
if: ${{ always() }}
run: cat community-build/dotty-community-build-deps || true

community_build_c:
runs-on: [self-hosted, Linux]
container:
image: lampepfl/dotty:2024-10-18
options: --cpu-shares 4096
volumes:
- ${{ github.workspace }}/../../cache/sbt:/root/.sbt
- ${{ github.workspace }}/../../cache/ivy:/root/.ivy2/cache
- ${{ github.workspace }}/../../cache/general:/root/.cache
if: "github.event_name == 'schedule' && github.repository == 'scala/scala3'
|| github.event_name == 'push'
|| github.event_name == 'merge_group'
|| (
github.event_name == 'pull_request'
&& !contains(github.event.pull_request.body, '[skip ci]')
&& !contains(github.event.pull_request.body, '[skip community_build]')
&& !contains(github.event.pull_request.body, '[skip community_build_c]')
)
|| (
github.event_name == 'workflow_dispatch'
&& github.repository == 'scala/scala3'
)"

steps:
##############################################################################################
## WARNING: DO NOT CHANGE THE JAVA VERSION HERE. SCALA 3.8.0+ IS DISTRIBUTED USING JAVA 17. ##
##############################################################################################
- name: Set JDK 17 as default
run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH
- name: Reset existing repo
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git -c "http.https://github.com/.extraheader=" fetch --recurse-submodules=no "https://github.com/scala/scala3" && git reset --hard FETCH_HEAD || true

- name: Checkout cleanup script
uses: actions/checkout@v5

- name: Cleanup
run: .github/workflows/cleanup.sh

- name: Git Checkout
uses: actions/checkout@v5

- name: Add SBT proxy repositories
run: cp -vf .github/workflows/repositories /root/.sbt/ ; true

- name: Test
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git submodule sync
git submodule update --init --recursive --jobs 7
./project/scripts/sbt "community-build/testOnly dotty.communitybuild.CommunityBuildTestC"

- name: Show dependency tracking file
if: ${{ always() }}
run: cat community-build/dotty-community-build-deps || true

publish_release:
permissions:
contents: write # for GH CLI to create a release
Expand All @@ -350,9 +179,8 @@ jobs:
- ${{ github.workspace }}/../../cache/sbt:/root/.sbt
- ${{ github.workspace }}/../../cache/ivy:/root/.ivy2/cache
- ${{ github.workspace }}/../../cache/general:/root/.cache
needs: [test, community_build_a, community_build_b, community_build_c, build-sdk-package, build-msi-package]
if: "github.event_name == 'push'
&& startsWith(github.event.ref, 'refs/tags/')"
needs: [test, build-sdk-package, build-msi-package]
if: "github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/')"

env:
RELEASEBUILD: yes
Expand Down
55 changes: 55 additions & 0 deletions .github/workflows/stdlib.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -599,3 +599,58 @@ jobs:
- uses: sbt/setup-sbt@v1
- name: Run SBT scripted tests
run: ./project/scripts/sbt scala3-bootstrapped-new/scripted

community_build_a:
runs-on: ubuntu-latest
steps:
- name: Checkout cleanup script
uses: actions/checkout@v5
with:
submodules: true
- name: Set up JDK 17
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 17
cache: 'sbt'
- uses: sbt/setup-sbt@v1
- name: Run Community Build A
run: |
./project/scripts/sbt "community-build/testOnly dotty.communitybuild.CommunityBuildTestA"

community_build_b:
runs-on: ubuntu-latest
steps:
- name: Checkout cleanup script
uses: actions/checkout@v5
with:
submodules: true
- name: Set up JDK 17
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 17
cache: 'sbt'
- uses: sbt/setup-sbt@v1
- name: Run Community Build B
run: |
./project/scripts/sbt "community-build/testOnly dotty.communitybuild.CommunityBuildTestB"


community_build_c:
runs-on: ubuntu-latest
steps:
- name: Checkout cleanup script
uses: actions/checkout@v5
with:
submodules: true
- name: Set up JDK 17
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 17
cache: 'sbt'
- uses: sbt/setup-sbt@v1
- name: Run Community Build C
run: |
./project/scripts/sbt "community-build/testOnly dotty.communitybuild.CommunityBuildTestC"
8 changes: 4 additions & 4 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
url = https://github.com/dotty-staging/intent
[submodule "community-build/community-projects/utest"]
path = community-build/community-projects/utest
url = https://github.com/dotty-staging/utest.git
url = https://github.com/dotty-staging/utest-new.git
[submodule "community-build/community-projects/os-lib"]
path = community-build/community-projects/os-lib
url = https://github.com/dotty-staging/os-lib.git
Expand Down Expand Up @@ -90,9 +90,9 @@
[submodule "community-build/community-projects/PPrint"]
path = community-build/community-projects/PPrint
url = https://github.com/dotty-staging/PPrint.git
[submodule "community-build/community-projects/requests-scala"]
path = community-build/community-projects/requests-scala
url = https://github.com/dotty-staging/requests-scala.git
[submodule "community-build/community-projects/requests"]
path = community-build/community-projects/requests
url = https://github.com/dotty-staging/requests.git
[submodule "community-build/community-projects/cats-effect-3"]
path = community-build/community-projects/cats-effect-3
url = https://github.com/dotty-staging/cats-effect.git
Expand Down
2 changes: 1 addition & 1 deletion community-build/community-projects/Monocle
Submodule Monocle updated 173 files
2 changes: 1 addition & 1 deletion community-build/community-projects/cask
Submodule cask updated 130 files
2 changes: 1 addition & 1 deletion community-build/community-projects/os-lib
Submodule os-lib updated 101 files
1 change: 1 addition & 0 deletions community-build/community-projects/requests
Submodule requests added at dd1768
1 change: 0 additions & 1 deletion community-build/community-projects/requests-scala
Submodule requests-scala deleted from 8e4a40
2 changes: 1 addition & 1 deletion community-build/community-projects/spire
Submodule spire updated 62 files
+22 −0 .git-blame-ignore-revs
+224 −97 .github/workflows/ci.yml
+1 −1 .scalafmt.conf
+0 −6 CODE_OF_CONDUCT.md
+34 −33 benchmark/src/main/scala/spire/benchmark/ComplexAddBenchmarks.scala
+69 −54 benchmark/src/main/scala/spire/benchmark/SelectionBenchmarks.scala
+12 −45 benchmark/src/main/scala/spire/benchmark/SieveBenchmark.scala
+137 −90 benchmark/src/main/scala/spire/benchmark/SortingBenchmarks.scala
+19 −43 build.sbt
+10 −7 core/src/main/scala-2/spire/syntax/Syntax.scala
+10 −7 core/src/main/scala-3/spire/syntax/Syntax.scala
+2 −2 core/src/main/scala/spire/algebra/free/FreeAbGroup.scala
+2 −2 core/src/main/scala/spire/math/Algebraic.scala
+1 −1 core/src/main/scala/spire/math/FastComplex.scala
+4 −4 core/src/main/scala/spire/math/Interval.scala
+1 −1 core/src/main/scala/spire/math/Merging.scala
+1 −1 core/src/main/scala/spire/math/Quaternion.scala
+5 −4 core/src/main/scala/spire/math/Rational.scala
+1 −1 core/src/main/scala/spire/math/SafeLong.scala
+32 −32 core/src/main/scala/spire/math/Selection.scala
+1 −4 core/src/main/scala/spire/math/poly/Term.scala
+1 −1 core/src/main/scala/spire/optional/Perm.scala
+1 −1 core/src/main/scala/spire/random/Ziggurat.scala
+1 −1 core/src/main/scala/spire/random/rng/Utils.scala
+1 −1 core/src/main/scala/spire/std/bigInteger.scala
+1 −2 core/src/main/scala/spire/std/map.scala
+1 −0 core/src/main/scala/spire/syntax/package.scala
+8 −5 docs/guide.md
+7 −7 docs/index.md
+19 −17 examples/src/main/scala/spire/example/endoring.scala
+1 −1 examples/src/main/scala/spire/example/infset.scala
+7 −6 extras/src/main/scala/spire/math/extras/interval/IntervalSeq.scala
+4 −4 extras/src/main/scala/spire/math/extras/interval/IntervalTrie.scala
+2 −2 laws/src/main/scala/spire/laws/LatticeLaws.scala
+11 −10 laws/src/main/scala/spire/laws/LogicLaws.scala
+2 −5 laws/src/main/scala/spire/laws/RingLaws.scala
+9 −6 laws/src/main/scala/spire/laws/gen.scala
+0 −0 platform/js-native/src/main/scala/spire/Platform.scala
+1 −1 project/build.properties
+0 −1 project/build.sbt
+6 −11 project/plugins.sbt
+6 −6 tests/shared/src/test/scala/spire/SyntaxScalaCheckSuite.scala
+1 −1 tests/shared/src/test/scala/spire/algebra/RingSuite.scala
+3 −1 tests/shared/src/test/scala/spire/laws/LawSuite.scala
+7 −1 tests/shared/src/test/scala/spire/math/AlgebraicScalaCheckSuite.scala
+43 −43 tests/shared/src/test/scala/spire/math/IntervalSyntaxSuite.scala
+8 −8 tests/shared/src/test/scala/spire/math/JetSuite.scala
+10 −4 tests/shared/src/test/scala/spire/math/PolynomialScalaCheckSuite.scala
+5 −5 tests/shared/src/test/scala/spire/math/PolynomialSuite.scala
+6 −0 tests/shared/src/test/scala/spire/math/QuaternionScalaCheckSuite.scala
+6 −0 tests/shared/src/test/scala/spire/math/RationalSuite.scala
+8 −26 tests/shared/src/test/scala/spire/math/RealScalaCheckSuite.scala
+11 −13 tests/shared/src/test/scala/spire/math/SafeLongScalaCheckSuite.scala
+3 −3 tests/shared/src/test/scala/spire/math/SafeLongSuite.scala
+1 −1 tests/shared/src/test/scala/spire/math/extras/FixedPointScalaCheckSuite.scala
+10 −10 tests/shared/src/test/scala/spire/math/extras/interval/IntervalSeqSuite.scala
+2 −2 tests/shared/src/test/scala/spire/math/interval/BoundScalaCheckSuite.scala
+6 −0 tests/shared/src/test/scala/spire/math/prime/FactorsScalaCheckSuite.scala
+0 −13 tests/shared/src/test/scala/spire/syntax/CforSuite.scala
+17 −17 tests/shared/src/test/scala/spire/syntax/LiteralsSuite.scala
+1 −2 tests/shared/src/test/scala/spire/util/OptSuite.scala
+1 −1 util/src/main/scala/spire/util/Opt.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/upickle
Submodule upickle updated 151 files
2 changes: 1 addition & 1 deletion community-build/community-projects/utest
Submodule utest updated 95 files
+17 −25 .github/workflows/actions.yml
+1 −0 .gitignore
+0 −1 .mill-version
+21 −0 LICENSE
+158 −0 build.mill
+0 −133 build.sc
+ docs/Golden.png
+ docs/PrettyPrint.png
+ docs/Splash.png
+314 −30 mill
+374 −168 readme.md
+0 −7 utest/js/test/src-2/test/utest/TestUtil.scala
+0 −7 utest/js/test/src-3/test/utest/TestUtil.scala
+0 −16 utest/jvm/test/src/test/utest/TestUtil.scala
+0 −7 utest/native/test/src-2/test/utest/TestUtil.scala
+0 −7 utest/native/test/src-3/test/utest/TestUtil.scala
+36 −0 utest/src-2-jvm/utest/framework/GoldenSpanMacros.scala
+1 −4 utest/src-2-jvm/utest/framework/PlatformShims.scala
+0 −5 utest/src-2.11/utest/asserts/MacroCompat.scala
+4 −1 utest/src-2/utest/Tests.scala
+16 −15 utest/src-2/utest/asserts/AssertsVersionSpecific.scala
+4 −4 utest/src-2/utest/asserts/ParallelVersionSpecific.scala
+30 −3 utest/src-2/utest/asserts/Tracer.scala
+1 −1 utest/src-3-jvm/utest/framework/EnableReflectiveInstantiation.java
+24 −0 utest/src-3-jvm/utest/framework/GoldenSpanMacros.scala
+2 −5 utest/src-3-jvm/utest/framework/PlatformShims.scala
+49 −2 utest/src-3-jvm/utest/framework/PortableScalaReflectExcerpts.scala
+41 −30 utest/src-3/utest/TestBuilder.scala
+16 −13 utest/src-3/utest/asserts/AssertsVersionSpecific.scala
+0 −21 utest/src-3/utest/asserts/Parallel.scala
+21 −0 utest/src-3/utest/asserts/ParallelVersionSpecific.scala
+39 −10 utest/src-3/utest/asserts/Tracer.scala
+5 −0 utest/src-js/utest/asserts/AssertsPlatformSpecific.scala
+6 −4 utest/src-js/utest/framework/PlatformShims.scala
+9 −0 utest/src-js/utest/framework/TestSuitePlatformSpecific.scala
+65 −0 utest/src-jvm/utest/asserts/AssertsPlatformSpecific.scala
+95 −0 utest/src-jvm/utest/framework/GoldenFix.scala
+4 −3 utest/src-jvm/utest/framework/PlatformShims.scala
+21 −0 utest/src-jvm/utest/framework/TestSuitePlatformSpecific.scala
+5 −0 utest/src-native/utest/asserts/AssertsPlatformSpecific.scala
+6 −12 utest/src-native/utest/framework/PlatformShims.scala
+10 −0 utest/src-native/utest/framework/TestSuitePlatformSpecific.scala
+123 −6 utest/src/utest/Errors.scala
+7 −5 utest/src/utest/TestRunner.scala
+3 −3 utest/src/utest/TestSuite.scala
+27 −1 utest/src/utest/Tests.scala
+4 −3 utest/src/utest/asserts/Asserts.scala
+3 −3 utest/src/utest/asserts/Parallel.scala
+9 −9 utest/src/utest/framework/DefaultFormatters.scala
+70 −46 utest/src/utest/framework/Formatter.scala
+12 −4 utest/src/utest/framework/Model.scala
+3 −0 utest/src/utest/framework/Tree.scala
+0 −49 utest/src/utest/package.scala
+38 −26 utest/src/utest/runner/BaseRunner.scala
+6 −0 utest/src/utest/runner/Fingerprint.scala
+1 −1 utest/src/utest/runner/Framework.scala
+6 −2 utest/src/utest/runner/MasterRunner.scala
+2 −2 utest/src/utest/runner/Task.scala
+0 −927 utest/src/utest/ufansi/Fansi.scala
+0 −22 utest/test/src-2.11/test/utest/Scala211Tests.scala
+14 −2 utest/test/src-2.12-jvm/test/utest/FormatterTests.scala
+3 −3 utest/test/src-2.12/test/utest/LazyValTest.scala
+28 −27 utest/test/src-2/test/utest/AssertsTestsVersionSpecific.scala
+9 −10 utest/test/src-3/test/utest/AssertsTestsVersionSpecific.scala
+0 −0 utest/test/src-js/test/utest/DefaultParamsTests.scala
+0 −0 utest/test/src-js/test/utest/Scheduler.scala
+101 −0 utest/test/src-jvm/test/utest/GoldenFixTests.scala
+152 −0 utest/test/src-jvm/test/utest/LineNumbersTests.scala
+38 −27 utest/test/src-jvm/test/utest/Parallel.scala
+0 −0 utest/test/src-jvm/test/utest/Scheduler.scala
+76 −0 utest/test/src-jvm/test/utest/SelectorTest.scala
+0 −0 utest/test/src-native/test/utest/Scheduler.scala
+1 −1 utest/test/src/test/utest/AfterEachOnFailureTest.scala
+177 −45 utest/test/src/test/utest/AssertsTests.scala
+3 −3 utest/test/src/test/utest/BeforeAfterAllFailureTest.scala
+1 −1 utest/test/src/test/utest/BeforeAfterEachFailureTests.scala
+1 −1 utest/test/src/test/utest/ByNameTests.scala
+1 −1 utest/test/src/test/utest/DisablePrint2Tests.scala
+2 −1 utest/test/src/test/utest/DisablePrintTests.scala
+1 −1 utest/test/src/test/utest/FrameworkAsyncTests.scala
+5 −5 utest/test/src/test/utest/FrameworkTests.scala
+2 −2 utest/test/src/test/utest/FutureCrashTest.scala
+17 −0 utest/test/src/test/utest/FutureTest.scala
+5 −30 utest/test/src/test/utest/Main.scala
+44 −0 utest/test/src/test/utest/MergeTestsTest.scala
+1 −1 utest/test/src/test/utest/QueryTests.scala
+7 −7 utest/test/src/test/utest/RetryTests.scala
+33 −0 utest/test/src/test/utest/TestDiscoveryTests.scala
+2 −2 utest/test/src/test/utest/examples/BeforeAfterAllTest.scala
+1 −1 utest/test/src/test/utest/examples/BeforeAfterEachTests.scala
+26 −17 utest/test/src/test/utest/examples/HelloTests.scala
+1 −1 utest/test/src/test/utest/examples/NestedTests.scala
+1 −1 utest/test/src/test/utest/examples/SeparateSetupTests.scala
+1 −1 utest/test/src/test/utest/examples/SharedFixturesTests.scala
+1 −1 utest/test/src/test/utest/examples/TestPathTests.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/verify
13 changes: 8 additions & 5 deletions community-build/src/scala/dotty/communitybuild/projects.scala
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,17 @@ end CommunityProject
final case class MillCommunityProject(
project: String,
baseCommand: String,
ignoreDocs: Boolean = false
ignoreDocs: Boolean = false,
sourcecodeTestCommand: Boolean = false,
) extends CommunityProject:
override val binaryName: String = "./mill"
override val testCommand = s"$baseCommand.test"
override val testCommand = if sourcecodeTestCommand then s"$baseCommand.test.run" else s"$baseCommand.test"
override val publishCommand = s"$baseCommand.publishLocal"
override val docCommand = null
// uncomment once mill is released
// if ignoreDocs then null else s"$baseCommand.docJar"
override val runCommandsArgs = List("-i", "-D", s"dottyVersion=$compilerVersion")
override val environment = Map.empty

final case class SbtCommunityProject(
project: String,
Expand Down Expand Up @@ -145,7 +147,8 @@ object projects:
lazy val sourcecode = MillCommunityProject(
project = "sourcecode",
baseCommand = s"sourcecode.jvm[$compilerVersion]",
ignoreDocs = true
ignoreDocs = true,
sourcecodeTestCommand = true,
)

lazy val oslib = MillCommunityProject(
Expand Down Expand Up @@ -202,8 +205,8 @@ object projects:
)

lazy val requests = MillCommunityProject(
project = "requests-scala",
baseCommand = s"requests[$compilerVersion]",
project = "requests",
baseCommand = s"requests.jvm[$compilerVersion]",
)

lazy val cask = MillCommunityProject(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ given testRunner: CommunityBuildRunner with
class CommunityBuildTestA:
@Test def izumiReflect = projects.izumiReflect.run()
@Test def scalaSTM = projects.scalaSTM.run()
@Test def scalatest = projects.scalatest.run()
//@Test def scalatest = projects.scalatest.run()
@Test def scalatestplusTestNG = projects.scalatestplusTestNG.run()
// 'Sciss/Lucre' dependencies:
// @Test def scissEqual = projects.scissEqual .run()
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/ast/Desugar.scala
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ object desugar {
case Some(param) if param.mods.isOneOf(GivenOrImplicit) =>
param.mods.flags & GivenOrImplicit
case _ =>
if Feature.sourceVersion.isAtLeast(`3.6`) then Given
if Feature.sourceVersion.isAtLeast(`3.6`) && !Feature.sourceVersion.isScala2 then Given
else Implicit
val flags = if isPrimaryConstructor then iflag | LocalParamAccessor else iflag | Param
mapParamss(paramss) {
Expand Down
Loading
Loading