Skip to content

Conversation

@soronpo
Copy link
Contributor

@soronpo soronpo commented Oct 24, 2025

def applyKind: ApplyKind =
attachmentOrElse(untpd.KindOfApply, ApplyKind.Regular)

def setEndMarker(): this.type =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already an existing WithEndMarker trait that implements this behavior

@soronpo
Copy link
Contributor Author

soronpo commented Oct 25, 2025

Are the tests in the main branch supposed to be working correctly? These changes were fine locally for 3.7.4, but I can't get the main branch to test successfully even without any modifications.

@hamzaremmal
Copy link
Member

hamzaremmal commented Oct 25, 2025

@soronpo I haven't checked why this PR doesn't pass in details as I'm on my phone, but from the diff, I would say that you need to add the object in scala.Predef, not just stdlibPatches.
And to answer your question, of course the tests are supposed to work correctly :).

@bishabosha
Copy link
Member

[error] Test dotty.tools.pc.tests.completion.CompletionBacktickSuite.soft-keyword-ident failed: java.lang.AssertionError:
[error] expected single completion item, obtained 2 items.
[error] List(end: Int
[error] , endMarkersForMethodBlocks - scala.runtime.stdLibPatches.language.experimental
[error] )
[error] , took 0.234 sec
[info] Test run dotty.tools.pc.tests.completion.Co

@soronpo looks like your new definition adds a new completion in this test

@soronpo
Copy link
Contributor Author

soronpo commented Oct 26, 2025

[error] Test dotty.tools.pc.tests.completion.CompletionBacktickSuite.soft-keyword-ident failed: java.lang.AssertionError:
[error] expected single completion item, obtained 2 items.
[error] List(end: Int
[error] , endMarkersForMethodBlocks - scala.runtime.stdLibPatches.language.experimental
[error] )
[error] , took 0.234 sec
[info] Test run dotty.tools.pc.tests.completion.Co

@soronpo looks like your new definition adds a new completion in this test

Blame the AI, hahaha. I'll check it out, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants