Skip to content

Fix import for futureEitherOr for-comprehension example to work #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
githubmo wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix import for futureEitherOr for-comprehension example to work #180

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adfab4c
Fix import for futureEitherOr for-comprehension example to work
githubmo Apr 18, 2020
3b70f87
Adding the Await and duration imports where they are needed
githubmo Apr 18, 2020
82a4f0a
Fixed weird formatting for `addAll` and adding missing dep
githubmo Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pages/monad-transformers/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,8 @@ cut through three layers of abstraction:

```scala mdoc:silent
import cats.instances.future._ // for Monad
import scala.concurrent.Await
import cats.syntax.applicative._ // for pure
import scala.concurrent.ExecutionContext.Implicits.global
import scala.concurrent.duration._
```

```scala mdoc:silent
Expand Down Expand Up @@ -399,6 +398,9 @@ For example, to `Await` the `FutureEitherOption` stack above,
we need to call `value` twice:

```scala mdoc
import scala.concurrent.Await
import scala.concurrent.duration._

futureEitherOr

val intermediate = futureEitherOr.value
Expand Down Expand Up @@ -455,6 +457,7 @@ import cats.data.EitherT
import cats.instances.list._
import scala.concurrent.Future
```

```scala mdoc:silent
sealed abstract class HttpError
final case class NotFound(item: String) extends HttpError
Expand Down Expand Up @@ -490,6 +493,7 @@ def parseNumber(str: String): Logged[Option[Int]] =
// Consumers use monad transformers locally to simplify composition:
def addAll(a: String, b: String, c: String): Logged[Option[Int]] = {
import cats.data.OptionT
import cats.instances.list._

val result = for {
a <- OptionT(parseNumber(a))
Expand Down