-
Notifications
You must be signed in to change notification settings - Fork 67
Make model-engine FIPS compliant by updating base chainguard image #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValentineDragan
wants to merge
28
commits into
main
Choose a base branch
from
fix/fix-vulnerabilities-in-model-engine-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make model-engine FIPS compliant by updating base chainguard image #724
ValentineDragan
wants to merge
28
commits into
main
from
fix/fix-vulnerabilities-in-model-engine-image
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues when creating endpoints
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dmchoiboi
reviewed
Oct 29, 2025
| {{- end }} | ||
| {{- end }} | ||
| {{- if $config_values }} | ||
| - name: service-config-volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if you needed to add this for specific reason? do you actually use batch-job-orchestration-job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR upgrades the model-engine Docker base image to use Chainguard's FIPS-compliant Python image, and fixes bugs in the CircleCI integration tests.
FIPS compliance changes:
Dockerfileto use chainguard base image for FIPS compliancefederal/Dockerfilecopycelery_enable_sha256: truein all configs for FIPS complianceFixing integration tests:
Test Plan and Usage Guide