-
Notifications
You must be signed in to change notification settings - Fork 0
[DRAFT]: adding the integration test workflow #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new GitHub Actions workflow for running integration tests that leverages a reusable workflow for building AgentEx images. The integration test workflow allows manual triggering with an optional commit SHA parameter and includes placeholder steps for actual test implementation.
Key changes:
- Added integration test workflow with manual dispatch trigger
- Created reusable build workflow for AgentEx server and auth images
- Implemented image discovery and pulling logic with placeholder integration tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/integration-tests.yml |
Main integration test workflow with image building, discovery, and test execution jobs |
.github/workflows/build-agentex.yml |
Reusable workflow for building and pushing AgentEx Docker images to GHCR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/build-agentex.yml
Outdated
| workflow_call: | ||
| commit-sha: | ||
| description: "Commit SHA to release (defaults to latest commit on main)" | ||
| required: true |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit-sha input is marked as required but has a default value. This creates confusion since required inputs cannot have defaults in GitHub Actions. Either set required: false or remove the default value.
| required: true | |
| required: false |
.github/workflows/build-agentex.yml
Outdated
| commit-sha: | ||
| description: "Commit SHA to release (defaults to latest commit on main)" | ||
| required: true | ||
| type: string | ||
| default: github.sha |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing inputs: key under workflow_call. The correct structure should be workflow_call:\n inputs:\n commit-sha:
| commit-sha: | |
| description: "Commit SHA to release (defaults to latest commit on main)" | |
| required: true | |
| type: string | |
| default: github.sha | |
| inputs: | |
| commit-sha: | |
| description: "Commit SHA to release (defaults to latest commit on main)" | |
| required: true | |
| type: string | |
| default: github.sha |
| echo "🔍 Discovering available images..." | ||
| # Get packages, excluding the current repo to avoid conflicts | ||
| PACKAGES=$(gh api repos/scaleapi/agentex-python/packages?package_type=container --jq '.[].name') echo "📦 Available packages:" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline character between the command assignment and echo statement. This will cause the commands to be concatenated on the same line, resulting in a syntax error.
| PACKAGES=$(gh api repos/scaleapi/agentex-python/packages?package_type=container --jq '.[].name') echo "📦 Available packages:" | |
| PACKAGES=$(gh api repos/scaleapi/agentex-python/packages?package_type=container --jq '.[].name') | |
| echo "📦 Available packages:" |
| docker pull ghcr.io/your-org/repo-name/image-name:tag | ||
| docker pull ghcr.io/your-org/another-repo/service:latest |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are placeholder Docker image references that will fail in execution. They should be replaced with actual image names or removed if not yet implemented.
| docker pull ghcr.io/your-org/repo-name/image-name:tag | |
| docker pull ghcr.io/your-org/another-repo/service:latest | |
| # TODO: Add actual docker pull commands for real images here, or uncomment the dynamic pull logic above. |
.github/workflows/build-agentex.yml
Outdated
| # .github/workflows/release.yml | ||
| name: Release AgentEx |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename comment references 'release.yml' but the actual filename is 'build-agentex.yml'. The workflow name should also be updated to reflect its purpose as a build workflow rather than a release workflow.
| # .github/workflows/release.yml | |
| name: Release AgentEx | |
| # .github/workflows/build-agentex.yml | |
| name: Build and Push AgentEx Images |
.github/workflows/build-agentex.yml
Outdated
| push: true | ||
| tags: | | ||
| ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }}:${{ inputs.commit-sha }} | ||
| ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }} |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auth image is being tagged without a version on line 87, which could cause issues with image identification. Consider adding a consistent tag pattern like :latest or removing this unversioned tag if not needed.
| ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }} | |
| ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }}:latest |
067c101 to
81a9483
Compare
ec09387 to
0f37ef7
Compare
0f37ef7 to
288bde6
Compare
0167fbf to
f56374e
Compare
f56374e to
3cbc59b
Compare
No description provided.