Skip to content

Conversation

@RoxyFarhad
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings October 29, 2025 16:59
@RoxyFarhad RoxyFarhad changed the title adding the integration test workflow [DRAFT]: adding the integration test workflow Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow for running integration tests that leverages a reusable workflow for building AgentEx images. The integration test workflow allows manual triggering with an optional commit SHA parameter and includes placeholder steps for actual test implementation.

Key changes:

  • Added integration test workflow with manual dispatch trigger
  • Created reusable build workflow for AgentEx server and auth images
  • Implemented image discovery and pulling logic with placeholder integration tests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/integration-tests.yml Main integration test workflow with image building, discovery, and test execution jobs
.github/workflows/build-agentex.yml Reusable workflow for building and pushing AgentEx Docker images to GHCR

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

workflow_call:
commit-sha:
description: "Commit SHA to release (defaults to latest commit on main)"
required: true
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit-sha input is marked as required but has a default value. This creates confusion since required inputs cannot have defaults in GitHub Actions. Either set required: false or remove the default value.

Suggested change
required: true
required: false

Copilot uses AI. Check for mistakes.
Comment on lines 6 to 10
commit-sha:
description: "Commit SHA to release (defaults to latest commit on main)"
required: true
type: string
default: github.sha
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing inputs: key under workflow_call. The correct structure should be workflow_call:\n inputs:\n commit-sha:

Suggested change
commit-sha:
description: "Commit SHA to release (defaults to latest commit on main)"
required: true
type: string
default: github.sha
inputs:
commit-sha:
description: "Commit SHA to release (defaults to latest commit on main)"
required: true
type: string
default: github.sha

Copilot uses AI. Check for mistakes.
echo "🔍 Discovering available images..."
# Get packages, excluding the current repo to avoid conflicts
PACKAGES=$(gh api repos/scaleapi/agentex-python/packages?package_type=container --jq '.[].name') echo "📦 Available packages:"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline character between the command assignment and echo statement. This will cause the commands to be concatenated on the same line, resulting in a syntax error.

Suggested change
PACKAGES=$(gh api repos/scaleapi/agentex-python/packages?package_type=container --jq '.[].name') echo "📦 Available packages:"
PACKAGES=$(gh api repos/scaleapi/agentex-python/packages?package_type=container --jq '.[].name')
echo "📦 Available packages:"

Copilot uses AI. Check for mistakes.
Comment on lines 54 to 58
docker pull ghcr.io/your-org/repo-name/image-name:tag
docker pull ghcr.io/your-org/another-repo/service:latest
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are placeholder Docker image references that will fail in execution. They should be replaced with actual image names or removed if not yet implemented.

Suggested change
docker pull ghcr.io/your-org/repo-name/image-name:tag
docker pull ghcr.io/your-org/another-repo/service:latest
# TODO: Add actual docker pull commands for real images here, or uncomment the dynamic pull logic above.

Copilot uses AI. Check for mistakes.
Comment on lines 1 to 2
# .github/workflows/release.yml
name: Release AgentEx
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename comment references 'release.yml' but the actual filename is 'build-agentex.yml'. The workflow name should also be updated to reflect its purpose as a build workflow rather than a release workflow.

Suggested change
# .github/workflows/release.yml
name: Release AgentEx
# .github/workflows/build-agentex.yml
name: Build and Push AgentEx Images

Copilot uses AI. Check for mistakes.
push: true
tags: |
ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }}:${{ inputs.commit-sha }}
ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }}
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auth image is being tagged without a version on line 87, which could cause issues with image identification. Consider adding a consistent tag pattern like :latest or removing this unversioned tag if not needed.

Suggested change
ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }}
ghcr.io/${{ github.repository }}/${{ env.AGENTEX_AUTH_IMAGE_NAME }}:latest

Copilot uses AI. Check for mistakes.
@RoxyFarhad RoxyFarhad force-pushed the RF/add-integration-wf branch 6 times, most recently from 067c101 to 81a9483 Compare October 29, 2025 17:57
@RoxyFarhad RoxyFarhad force-pushed the RF/add-integration-wf branch 2 times, most recently from ec09387 to 0f37ef7 Compare October 29, 2025 20:45
@RoxyFarhad RoxyFarhad force-pushed the RF/add-integration-wf branch from 0f37ef7 to 288bde6 Compare October 29, 2025 20:47
@RoxyFarhad RoxyFarhad force-pushed the RF/add-integration-wf branch from 0167fbf to f56374e Compare October 29, 2025 21:23
@RoxyFarhad RoxyFarhad force-pushed the RF/add-integration-wf branch from f56374e to 3cbc59b Compare October 29, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants