Conversation
duncanphillips
commented
Jan 11, 2017
duncanphillips
commented
| <b>{{ speaker.name }}</b><br/> | ||
| {{ speaker.company}} | ||
| </p> | ||
| <a href="/speakers/{{ speaker.year }}#{{ speaker.name | slugify }}"> |
There was a problem hiding this comment.
speakers on home page are now linked properly
vhata
left a comment
vhata
left a comment
There was a problem hiding this comment.
The code itself is fine, but I don't like the layout in general. I've submitted a pull-request onto this branch with what I think are some improvements - see what you think, change them if you want?
| <p> {{ speaker.bio }} </p> | ||
| <div class="row nested-row"> | ||
| <div class="col-md-offset-1 col-md-11"> | ||
| <p> {{ speaker.bio }} </p> |
There was a problem hiding this comment.
Can we move the speaker bio below the abstract? The abstract is the important thing here - people are here for the talks, not to learn about the speakers lives.
| <p>The title of the talk is <i>"{{ speaker.title }}"</i>.</p> | ||
| <div class="row nested-row"> | ||
| <div class="col-md-offset-1 col-md-11"> | ||
| <p>The title of the talk is <i>"{{ speaker.title }}"</i>.</p> |
There was a problem hiding this comment.
This is weird. "The title of the talk is X". Can we make it look like a title, and put it with the abstract in a more prominent position? This page is basically listing the talks with their titles and abstracts, so it should look more like it.
| {% for speaker in page_speakers %} | ||
| <div id='{{ speaker.name | slugify }}'> | ||
| <div class="row text-center"> | ||
| <h2>{{ speaker.name }}</h2> |
There was a problem hiding this comment.
These names are huge. Again, could we make the talk title bigger and more titley, maybe combine them with the name here?
2 participants
