Skip to content

feat(lb): add private network resource #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2025
Merged

feat(lb): add private network resource #3153

merged 1 commit into from
Nov 13, 2025

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Jun 11, 2025

No description provided.

@yfodil yfodil self-assigned this Jun 11, 2025
@yfodil yfodil added enhancement load-balancer Load-balancer issues, bugs and feature requests labels Jun 11, 2025
@yfodil yfodil marked this pull request as ready for review June 11, 2025 12:51
@yfodil yfodil requested review from a team and remyleone as code owners June 11, 2025 12:51
@yfodil yfodil marked this pull request as draft June 12, 2025 08:39
@yfodil yfodil marked this pull request as ready for review September 10, 2025 07:45
@yfodil yfodil requested a review from a team as a code owner September 10, 2025 08:25
remyleone
remyleone reviewed Sep 17, 2025
View reviewed changes
remyleone
remyleone previously approved these changes Sep 18, 2025
View reviewed changes
@remyleone remyleone enabled auto-merge September 18, 2025 08:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 210 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.75%. Comparing base (948d2f1) to head (ba6460a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/lb/private_network.go 0.00% 141 Missing ⚠️
internal/services/vpc/testfuncs/checks.go 0.00% 37 Missing ⚠️
internal/services/lb/lb.go 0.00% 26 Missing ⚠️
internal/services/lb/helpers_lb.go 0.00% 5 Missing ⚠️
provider/sdkv2.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #3153      +/-   ##
=========================================
- Coverage    1.77%   1.75%   -0.02%     
=========================================
  Files         400     401       +1     
  Lines       43890   44082     +192     
=========================================
- Hits          779     775       -4     
- Misses      43024   43218     +194     
- Partials       87      89       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

remyleone
remyleone reviewed Nov 12, 2025
View reviewed changes
@github-actions github-actions bot added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Nov 13, 2025
remyleone
remyleone previously approved these changes Nov 13, 2025
View reviewed changes
@remyleone remyleone linked an issue Nov 13, 2025 that may be closed by this pull request
lb_private_network #2938
Closed
@yfodil
feat(lb): add private network resource
ba6460a 
- add tests
- add docs and cassettes
- manage PN attachments externally
- use zone from returned LB response
- add checks
@yfodil yfodil force-pushed the feat/add-lb-pn-resource branch from 585c8ff to ba6460a Compare November 13, 2025 12:37
@remyleone remyleone added this pull request to the merge queue Nov 13, 2025
Merged via the queue into scaleway:master with commit 5c63523 Nov 13, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels

baremetal enhancement load-balancer Load-balancer issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lb_private_network

3 participants

@yfodil @codecov-commenter @remyleone