Merged
Conversation
Some sysctl values return "tabs", this breakes the test for changes, since there is no sane way to specify tabs in the target value. this change converts tabs in the output of sysctl -n to two spaces. resolving this issue of false positive change detection
…more kernel settings.
Author
Owner
Author
|
Yeah, I'm requesting that you merge this in so that "thias" can then merge in the combination of changes. Your PR needs the change for your fix to fix "thias's" issue. Is that confusing enough? I'll see if I can get him to accept the pull request or donate it to Voxpupuli. |
Author
|
I sent another email to the project owner. It does look like he's fairly active still....just not with Puppet stuff. |
Owner
|
jeah, would be great if vox pupuli could take over maintenance. |
Author
|
@schlitzered, I'm not sure if I missed it but this PR should have gone into your tabs_to_spaces branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translating the tab from two characters to one character in the SED script supports more kernel parameters such as 'net.ipv4.ip_local_port_range'.