Apresenta a página do artigo com ou sem Crossmark via CrossmarkPage#414
Draft
Apresenta a página do artigo com ou sem Crossmark via CrossmarkPage#414
Conversation
Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update article page to include HTMLGenerator integration
Gera a página do artigo com ou sem Crossmark via CrossmarkPage
Mar 6, 2026
opac/webapp/controllers.py
Outdated
| journal=journal, language=lang, is_doi_active=True | ||
| ).first() | ||
| if crossmark: | ||
| return "https://doi.org/{}".format(crossmark.doi) |
Contributor
Author
There was a problem hiding this comment.
Done in 3a399fa. Updated get_crossmark_policy_page() to return crossmark.url directly. Also bumped the opac_schema dependency to commit 60cde78 which adds the url field to CrossmarkPage.
Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integra o modelo
CrossmarkPagedoopac_schemaao pipeline de renderização de artigos, passando a URL da política Crossmark aoHTMLGeneratorquando disponível para o periódico e idioma do artigo.O que esse PR faz?
requirements.txt: atualizaopac_schemapara o commit60cde78que adiciona o campourlao modeloCrossmarkPage, epacktoolspara o commit que adicionacrossmark_policy_pageaoHTMLGeneratorcontrollers.py: importaCrossmarkPage; adicionaget_crossmark_policy_page(journal, lang)que retornacrossmark.urlquando há registro ativo com URL preenchida, ouNoneviews.py: propagacrossmark_policy_pageporarticle_detail_v3→render_html→render_html_from_xml→HTMLGenerator.parse()tests/: adiciona helpermakeOneCrossmarkPage()eCrossmarkPolicyPageControllerTestCase(5 cenários: ativo com url, ativo sem url, inativo, ausente, idioma divergente)Onde a revisão poderia começar?
opac/webapp/controllers.py→get_crossmark_policy_page(), depoisopac/webapp/main/views.py→render_html_from_xmlearticle_detail_v3.Como este poderia ser testado manualmente?
CrossmarkPageno banco comjournal=<periódico>,language='pt',is_doi_active=True,doi='10.1590/seu-doi',url='https://www.crossref.org/crossmark-policy'?lang=ptcrossmark-cdn.crossref.org/widget) e do badgedata-target="crossmark"is_doi_active=False, ou deixarurlvazio) e confirmar que o HTML não contém elementos CrossmarkAlgum cenário de contexto que queira dar?
CrossmarkPagefoi adicionado aoopac_schemarecentemente (sem tag ainda); o campourlfoi acrescentado ao modelo para armazenar diretamente a URL da página de política, dispensando a construção manual da URL a partir do DOI.packtoolstem PR aberto (#1120) adicionandocrossmark_policy_pageaoHTMLGenerator. Ambas as dependências são referenciadas por SHA de commit até que novas releases sejam publicadas.Screenshots
N/A
Quais são tickets relevantes?
N/A
Referências
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.