Skip to content

[Snyk] Security upgrade gulp from 4.0.2 to 5.0.0 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertatakenaka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade gulp from 4.0.2 to 5.0.0 #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"bootstrap": "^3.1.1",
"gulp": "^4.0.2",
"gulp": "^5.0.0",
Copy link

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This major version upgrade from gulp 4.0.2 to 5.0.0 introduces breaking changes that may cause build failures. The gulpfile.js uses gulp-util on line 7, which is deprecated and not compatible with gulp 5.0. Additionally, gulp-minify-css (listed in dependencies) depends on gulp-util. Before merging, you should: 1) Replace gulp-util with its modern equivalents (fancy-log for logging, plugin-error for errors), 2) Update the package-lock.json as warned in the PR description, and 3) Test the build process to ensure all gulp tasks still work correctly with gulp 5.0.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json file has not been updated as part of this PR. The PR description explicitly warns "Failed to update the package-lock.json, please update manually before merging." This file must be updated before merging to ensure the correct versions of transitive dependencies are installed, particularly the patched versions of tar that fix the Directory Traversal vulnerabilities (SNYK-JS-TAR-15032660 and SNYK-JS-TAR-15127355).

Copilot uses AI. Check for mistakes.
"gulp-concat": "^2.6.1",
"gulp-less": "^4.0.1",
"gulp-clean": "^0.4.0",
Expand Down