feat: add support for SHA algorithms to improve switch and hardware compatibility #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for SHA Algorithm Support
NetPulse added SHA algorithm support primarily to improve compatibility with legacy network devices.
Core Reasons:
Legacy Device Support - Many older Cisco, hp_comware and other devices still use ssh-rsa algorithm and don't support newer SHA-2 algorithms
Hardware Compatibility - Enterprise networks contain many switches and routers with older firmware versions, requiring stable connection assurance
Unified Management - By enabling ssh-rsa globally through SSH configuration, achieving unified management of both new and old devices
Implementation:
Configured global SSH parameters in docker/ssh_config to ensure all Worker containers can connect to legacy devices, while the Netmiko driver also provides disable_sha2_fix parameter for flexible user configuration.
This design enables NetPulse to run stably in various network environments, whether with modern devices or legacy hardware.