Skip to content

Conversation

@0PandaDEV
Copy link
Contributor

I implemented macOS Code Signing as well as 3 build scripts to build Scope locally on the respective devices.

CleanShot 2024-11-18 at 11  29 25

For the Code Singing to work, there needs to be a few environment variables in this repo:

  • APPLE_CERTIFICATE: Base64 encoded .p12 certificate file
  • APPLE_CERTIFICATE_PASSWORD: Password for the certificate
  • APPLE_ID: Apple Developer ID Email
  • APPLE_ID_PASSWORD: App-specific password for your Apple ID
  • KEYCHAIN_PASSWORD: Any secure password for the temporary keychain

@0PandaDEV 0PandaDEV changed the title Add macOS Code Signing macOS Code Signing & Local build scripts & Improved Issue template Nov 18, 2024
@circularsprojects
Copy link
Contributor

if i remember correctly you can submit apps to the notary service without having to use apple id email/password, i'm gonna have a bit of a look at it

@circularsprojects
Copy link
Contributor

if i remember correctly you can submit apps to the notary service without having to use apple id email/password, i'm gonna have a bit of a look at it

i was right, you can make a signing profile with an app store connect api key, and then use that to notarize apps
image
you can then just use xcrun notarytool submit [path] --keychain-profile [profile]

not entirely sure how to do this via github actions though

@0PandaDEV
Copy link
Contributor Author

Ok, but this requires a Paid Developer account, which I don't have, so I can't test this.

@circularsprojects
Copy link
Contributor

Ok, but this requires a Paid Developer account, which I don't have, so I can't test this.

i can test it out in my fork

also doesn't using the notary service at all require a paid dev account?

@0PandaDEV
Copy link
Contributor Author

0PandaDEV commented Nov 18, 2024

No you can sign with a free account it will just pop up as unverified but at least it's no longer damaged.
CleanShot 2024-11-18 at 12  38 10

@circularsprojects
Copy link
Contributor

No you can sign with a free account it will just pop up as unverified but at least it's no longer damaged. CleanShot 2024-11-18 at 12  38 10

ohhh right

@vmfunc vmfunc self-requested a review November 18, 2024 06:52
@vmfunc vmfunc self-assigned this Nov 18, 2024
@vmfunc vmfunc added the chore edits to the workflow label Nov 18, 2024
@bvvst bvvst self-assigned this Nov 19, 2024
Copy link
Contributor

@alii alii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs APP_BUNDLE_ID to be loaded in actual workflow file. Can hardcode it in the yml file under env: i think

@0PandaDEV
Copy link
Contributor Author

so what should the that be?

com.scopeclient.scope ?

@alii
Copy link
Contributor

alii commented Nov 19, 2024

com.scopeclient.desktop imo

@0PandaDEV 0PandaDEV requested a review from alii November 19, 2024 04:34
@alii alii merged commit 866bdac into scopeclient:main Nov 19, 2024
1 check passed
alii added a commit that referenced this pull request Nov 19, 2024
* chore: add macos build script

* chore: linux and windows build scripts

* chore(actions): code singing for macos

* chore(actions): fix build error on silicon

* feat: issue templates as yml

* fix: remove print certificate

* feat: openssl for password and hardcode bundle id

* fix: typo

---------

Co-authored-by: Alistair Smith <hi@alistair.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore edits to the workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants