Merged
Conversation
Remove nlohmann_dump in preparation of adding it as a git subtree
git-subtree-dir: nlohmann_json git-subtree-split: 55f93686c01528224f448c19128836e7df245f72
Add bazel build files to make tests runnable with bazel
Unit tests can not be executed in one bazel test: see nlohmann_json/tests/src/BUILD line 54
Change test execution command to execute all tests
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Setting -LE git_required flag to avoid new cloning of nlohmann_json
Fixed clang tidy issues in macro_unscope.hpp and in std_fs.hpp
Fix format issues in bazel script and exclude format check of nlohmann pipeline
- Copy .clang-tidy from nlohmann to top level such that it is used by the corresponding github action
NilsEb
force-pushed
the
nilseb_nlohmann_json_as_subtree
branch
from
fc57068 to
e79b2dc
Compare
- Describe nlohmann_json intergration using the subtree method and how to pull changes from nlohmann_json
- Use google style and the .clang-tidy config in the linting action
- Fix typo in line 64 in linting.yml
- Fix typo in line 79 in linting.yml
- Exclude .clang_tidy in yamlfmt as the formatter suggests putting all options into a single line, which would reduce readability
NilsEb
force-pushed
the
nilseb_nlohmann_json_as_subtree
branch
from
93911cc to
827878b
Compare
Deactivated style checking in linting.yml since nlohmann_json does not follow a common style guide
- Removed unnecessary linting annotations
lennartbecker-d
approved these changes
Jun 30, 2025
Member
lennartbecker-d
left a comment
lennartbecker-d
left a comment
There was a problem hiding this comment.
Thanks for adding the subtree and improving the pipeline @NilsEb!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.