Add caller information #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to avoid string handling as much as possible these days. So this function shouldn't be called often, and we can remove this optimisation.
While user parameters seems to be the best fit for adding caller information, it does not seem the optimal solution, specialy as there is no linking to the sourcode in Vampir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first approach to exposing the Caller's information to Score-P.
The proper way would be to use
SCOREP_AddSourceCodeLocation, but this is currently not exposed through the API.Either we need a Score-P patch, or we need to use external ... however, I do prefer to patch Score-P.