Skip to content

added XDG_RUNTIME_DIR to container #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macdabby wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added XDG_RUNTIME_DIR to container #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
644e111
added XDG_RUNTIME_DIR to container
macdabby Oct 8, 2021
1079427
Merge branch 'master' into fix-for-wayland
macdabby Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-wine
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,7 @@ else

# Add Linux run args
add_run_arg --env="DISPLAY"
add_run_arg --volume="$XDG_RUNTIME_DIR/$WAYLAND_DISPLAY:/tmp/$WAYLAND_DISPLAY"
Copy link

@stuaxo stuaxo Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macdabby maybe it's worth putting this behind a conditional so it's set (as per feedback from @scottyhardy)

	if [ -v WAYLAND_DISPLAY ]; then
		 add_run_arg --volume="$XDG_RUNTIME_DIR/$WAYLAND_DISPLAY:/tmp/$WAYLAND_DISPLAY"
	fi

Copy link

@stuaxo stuaxo Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my local system XDG_RUNTIME_DIR is /run, will /tmp always work ?

Copy link

@onelittlehope onelittlehope Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it helps, the following docker command works for me:

docker run -it \
  --rm \
  --hostname="$(hostname)" \
  --env="DISPLAY" \
  --env="WAYLAND_DISPLAY" \
  --env XDG_RUNTIME_DIR="/run/user/$(id -u)" \
  --env USER_UID="$(id -u)" \
  --env USER_GID="$(id -g)" \
  --platform="linux/amd64" \
  --volume="${XAUTHORITY:-${HOME}/.Xauthority}:/home/wineuser/.Xauthority:ro" \
  --volume="/tmp/.X11-unix:/tmp/.X11-unix:ro" \
  --volume="$XDG_RUNTIME_DIR/$WAYLAND_DISPLAY:/run/user/$(id -u)/$WAYLAND_DISPLAY" \
  scottyhardy/docker-wine wine notepad

I'd like it to either be a command line option or have some way to auto-detect if wayland is in use.

if [ -n "${WAYLAND_DISPLAY:-}" ] && [ -e "$XDG_RUNTIME_DIR/$WAYLAND_DISPLAY" ]
  echo "Wayland desktop is in use"
fi

add_run_arg --volume="/tmp/.X11-unix:/tmp/.X11-unix:ro"

run_container "interactive"
Expand Down