Skip to content
This repository was archived by the owner on Nov 27, 2019. It is now read-only.

Conversation

@StevenMaude
Copy link

With a page size of 100, the API won't return results for page
100, page 99 is the last valid one.

Known issue: http://developer.zoopla.com/forum/read/162309

With a page size of 100, the API won't return results for page
100, page 99 is the last valid one.

Known issue: http://developer.zoopla.com/forum/read/162309
@StevenMaude
Copy link
Author

This arose because Zoopla were giving out seemingly bad results. For a particular postcode search, the first page of results had only 99 entries, instead of 100. Subsequent pages had the correct number of entries, but this meant that the number found was one lower than the expected result count.

Once the code reached page 100, it errored. Really, this shouldn't happen unless you're doing a big search (the example in the Zoopla forum was searching for properties in London).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be >= 100 if for example someone picks a specific page number > 100 rather than simply incrementing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants