-
Notifications
You must be signed in to change notification settings - Fork 93
Add shadow to popup for better visual distinction above keyboard #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Hey @Femimat 👋 I'm realizing that I might have been confused by the plans for this. Would we be able to add a small shadow to the views that's similar to what's under the keys? The background color for the alternate keys view should be the same as they keyboard background color. It'd be good if we had a shadow under it so it's clear that it's above they keyboard interface :) |
|
Hi @andrewtavis, I understand better now. I’ll go over it and see how I can implement the design. |
|
Sounds good, @Femimat! Looking forward to the update 😊 |
|
Hey @andrewtavis! I’ve updated the PR — please have a look when you get a chance. |
DeleMike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Femimat!
Thanks for the input!
Please can you avoid hardcoded colors - please reference a named color resource (e.g. @color/popup_shadow_color) for theme consistency.
- The popup looks a bit flat — maybe we can consider adding creating a more natural “shadowed” effect.
Nice work!
|
Hi @DeleMike! |
|
Thanks so much! And I'm looking forward to it :) |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds a subtle grey shadow (#3F3F46) to the popup view that appears when users long-press keys with alternate characters (e.g., accented letters).
The shadow visually separates the popup from the keyboard, making it clearer that the view is layered above.
This update ensures consistent appearance across both light and dark themes.
Changes Made
Updated minikeyboard_background.xml to include shadow properties.
Adjusted layout styling in keyboard_popup_keyboard.xml.
Related issue