Skip to content

Conversation

@Femimat
Copy link
Contributor

@Femimat Femimat commented Oct 7, 2025

Contributor checklist


Description

This PR adds a subtle grey shadow (#3F3F46) to the popup view that appears when users long-press keys with alternate characters (e.g., accented letters).
The shadow visually separates the popup from the keyboard, making it clearer that the view is layered above.
This update ensures consistent appearance across both light and dark themes.

Changes Made

Updated minikeyboard_background.xml to include shadow properties.
Adjusted layout styling in keyboard_popup_keyboard.xml.

Related issue

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Hey @Femimat 👋 I'm realizing that I might have been confused by the plans for this. Would we be able to add a small shadow to the views that's similar to what's under the keys? The background color for the alternate keys view should be the same as they keyboard background color. It'd be good if we had a shadow under it so it's clear that it's above they keyboard interface :)

@Femimat
Copy link
Contributor Author

Femimat commented Oct 8, 2025

Hi @andrewtavis, I understand better now. I’ll go over it and see how I can implement the design.

@andrewtavis
Copy link
Member

Sounds good, @Femimat! Looking forward to the update 😊

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 11, 2025
@Femimat Femimat changed the title Update background colors for keyboard popup (day/night themes) Add shadow to popup for better visual distinction above keyboard Oct 13, 2025
@Femimat
Copy link
Contributor Author

Femimat commented Oct 14, 2025

Hey @andrewtavis! I’ve updated the PR — please have a look when you get a chance.

Copy link
Collaborator

@DeleMike DeleMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Femimat!

Thanks for the input!


Please can you avoid hardcoded colors - please reference a named color resource (e.g. @color/popup_shadow_color) for theme consistency.

  • The popup looks a bit flat — maybe we can consider adding creating a more natural “shadowed” effect.

Nice work!

@Femimat
Copy link
Contributor Author

Femimat commented Oct 28, 2025

Hi @DeleMike!
I’ll go over it and see how I can implement the design. thanks for the feedback.

@DeleMike
Copy link
Collaborator

DeleMike commented Oct 28, 2025

Thanks so much! And I'm looking forward to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants