-
Notifications
You must be signed in to change notification settings - Fork 93
Fix/string remove #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/string remove #507
Conversation
…ibe-Android into fix/string-remove
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks for opening another PR, @omjamnekar! We'll get to the review in the coming days :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great First PR @omjamnekar. Happy to see that a lot of the unnecessary strings have been removed. We would merge this once the workflows succeeds.
|
So great to have this in, @omjamnekar :) Thanks for the work, and also thanks for the support and review @angrezichatterbox! 😊 |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request updates the
strings.xmlfile by:Related issue
app/src/main/res/values/strings.xml#466