Merged
Conversation
Ryang-21
previously approved these changes
Dec 2, 2025
Collaborator
Ryang-21
left a comment
Ryang-21
left a comment
There was a problem hiding this comment.
Couple questions but looks good otherwise
| APP_CONFIG.interestFillerAddress !== undefined && | ||
| APP_CONFIG.interestFillerAddress !== '' && | ||
| auctionBid.auctionEntry.auction_type == AuctionType.Interest && | ||
| fill.percent === 100 |
Collaborator
There was a problem hiding this comment.
is there a reason to fill using the interest filler contract when its a 100 percent fill?
Contributor
Author
There was a problem hiding this comment.
yep, still allows us to fill with USDC directly. Also prevents sim/fill block difference from causing failures
Comment on lines
245
to
253
| try { | ||
| logger.info( | ||
| `Scanning ${users.length} users for liquidations in pool: ${poolConfig.poolAddress}` | ||
| ); | ||
| } catch (e) { | ||
| const errorLog = `Error scanning for liquidations: ${poolConfig.poolAddress}\nError: ${e}`; | ||
| logger.error(errorLog); | ||
| sendNotification(errorLog); | ||
| } |
Collaborator
There was a problem hiding this comment.
This try catch meant to be around the logging?
Contributor
Author
There was a problem hiding this comment.
no, thx for catching
Ryang-21
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.