Adding a couple turrets-hosting-related docs#2
Open
ElliotFriend wants to merge 4 commits intoscript3:mainfrom
Open
Adding a couple turrets-hosting-related docs#2ElliotFriend wants to merge 4 commits intoscript3:mainfrom
ElliotFriend wants to merge 4 commits intoscript3:mainfrom
Conversation
Signed-off-by: Elliot J. Voris <elliot@voris.me>
Signed-off-by: Elliot J. Voris <elliot@voris.me>
Signed-off-by: Elliot J. Voris <elliot@voris.me>
mootz12
reviewed
Nov 18, 2021
Collaborator
mootz12
left a comment
mootz12
left a comment
There was a problem hiding this comment.
Looks good!
See one comment about additional material for turret hosts. This is NOT a requirement for approval, just an additional suggestion!
| @@ -0,0 +1,216 @@ | |||
| # Stellar Turrets Reference Implementation | |||
Collaborator
There was a problem hiding this comment.
Nice!
A cool addition would be some of the details in kalepail/stellar-turrets#36 about running more than one turret
Author
There was a problem hiding this comment.
Good call! Maybe I'll add some notes about testnet vs mainnet with a link to Tyler's PR, since it's still a work-in-progress?
Added a description of running two turrets, and linked to kalepail/stellar-turrets#36 for further information. Signed-off-by: Elliot J. Voris <elliot@voris.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied the reference implementation, and wrote a high-level overview of what a turret host is actually hosting.