Skip to content

Conversation

@jup31
Copy link
Collaborator

@jup31 jup31 commented Feb 26, 2016

Hereunder a description of the modifications done :

  • create a function from the initial code to allow a recursive call to render the Model included in the collection.
  • add 3 tag allowed by the script in the configuration file (collection, beginhtmltext, endhtmltext)
  • add in the new function a specific part to manage collection. A collection is render using :
    • beginhtmltext
    • recursive rendering of the collection model
    • endhtmltext

As it is my first pull request not sure how to do it.

@jup31
Copy link
Collaborator Author

jup31 commented Feb 27, 2016

I have log an issue in my repository regarding this change. I didn't manage the infinite loop case for the moment.

Issue 1

@scriptnull
Copy link
Owner

Once you are done with it , please comment it out here. So that , I will check it out and we will start to merge your changes .

@jup31
Copy link
Collaborator Author

jup31 commented Mar 1, 2016

Worked for me.

@jup31
Copy link
Collaborator Author

jup31 commented Mar 26, 2016

Have you done a test ?

@scriptnull
Copy link
Owner

Oops . I have been busy lately. Thanks for your contribution man. I think you should be a collaborator in this project. I really appreciate your work here. Please close this PR and commit directly to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants