unify all circuit to gkr-iop #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
feat/all_gkr_iop
branch
from
5521bca to
9ce2413
Compare
hero78119
changed the title
hero78119
force-pushed
the
feat/all_gkr_iop
branch
from
eaad6e4 to
164a7a6
Compare
This was referenced Oct 27, 2025
hero78119
commented
Nov 3, 2025
hero78119
commented
Nov 3, 2025
hero78119
commented
Nov 3, 2025
kunxian-xia
reviewed
Nov 4, 2025
kunxian-xia
reviewed
Nov 4, 2025
kunxian-xia
reviewed
Nov 4, 2025
Collaborator
kunxian-xia
left a comment
kunxian-xia
left a comment
There was a problem hiding this comment.
1st pass of code review
| descending: false, | ||
| }, | ||
| ); | ||
| let selector = cb.create_placeholder_structural_witin(|| "selector"); |
Collaborator
There was a problem hiding this comment.
we can remove this function as it's already covered in trait TableCircuit.
Build on top of #1092 ### change scopes - [x] verify api for continuation proofs - [x] exclude init tables on shard > 0 - [x] ceno-cli with multiple proofs - [x] separate fixed commitment into 2 set, one for first shard, the other for non-first shards - [x] multi-shards ci integration test ### design rationales `prover_id` and `num_provers` are exposed as CLI arguments to specify the number of physical provers in a cluster, each mark with a prover_id. The overall trace data is divided into `shards`, which are distributed evenly among the provers. The number of shards are in general agnostic to number of provers. Each prover is assigned `n` shard where n can be even empty Shard distribution follows a balanced allocation strategy — for example, if there are 10 shards and 3 provers, the shard counts will be distributed as 4, 3, and 3, ensuring an even workload across all provers. --------- Co-authored-by: xkx <xiakunxian130@gmail.com>
kunxian-xia
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build on top of #1084
changes
benchmark
With CPU
3-4% performance regressed
On GPU 5070 ti, CPU 5900XT
performance regressed a bit on smaller size is expected. On larger workload it even improve.
Think the reason is because we got less cuda kernel invocations during e2e