Skip to content

Documentation improvements#130

Draft
Zethson wants to merge 7 commits intomainfrom
feature/docs_improvements
Draft

Documentation improvements#130
Zethson wants to merge 7 commits intomainfrom
feature/docs_improvements

Conversation

@Zethson
Copy link
Member

@Zethson Zethson commented Jan 30, 2026

First set of suggested changes to improve documentation.

  • Uses correct admonition syntax - however this breaks the Github README sigh
  • Renames notebooks to tutorials
  • Minor fixes

Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zethson Zethson marked this pull request as draft January 30, 2026 13:40
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.06%. Comparing base (352f4f8) to head (582b318).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   93.71%   91.06%   -2.65%     
==========================================
  Files          10       10              
  Lines         795      795              
==========================================
- Hits          745      724      -21     
- Misses         50       71      +21     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Zethson
Copy link
Member Author

Zethson commented Jan 30, 2026

@ilan-gold I just noticed that the current admonition style works for Github READMEs but breaks for the myst based rendered docs. I think the only reasonable solution is to not include the whole README to use the right syntax at the right place. In other words, I'd slim down the README and move that content into a different place. WDYT?

@ilan-gold
Copy link
Collaborator

ilan-gold commented Jan 30, 2026

@ilan-gold I just noticed that the current admonition style works for Github READMEs but breaks for the myst based rendered docs. I think the only reasonable solution is to not include the whole README to use the right syntax at the right place. In other words, I'd slim down the README and move that content into a different place. WDYT?

@felix0097 has in the past been quite adamant about having the README be a bit self-contained. I think the admonition syntax not working there is a reasonable price to pay TBH

@ilan-gold
Copy link
Collaborator

Ideally we'd have a converted between the two (theoretically not a bad idea for scanpydoc actually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants