Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 93.71% 91.50% -2.21%
==========================================
Files 11 11
Lines 811 812 +1
==========================================
- Hits 760 743 -17
- Misses 51 69 +18
🚀 New features to boost your workflow:
|
ilan-gold
approved these changes
Feb 23, 2026
ilan-gold
approved these changes
Feb 25, 2026
src/annbatch/io.py
Outdated
| self, | ||
| *, | ||
| adata_paths: Iterable[PathLike[str]] | Iterable[str], | ||
| rng: np.random.Generator, |
Collaborator
There was a problem hiding this comment.
Moved as well, what I meant by "same in the other place this occurs"
ilan-gold
reviewed
Feb 25, 2026
| shuffle_chunk_size | ||
| How many contiguous rows to load into memory before shuffling at once. | ||
| `(shuffle_chunk_size // n_obs_per_dataset)` slices will be loaded of size `shuffle_chunk_size`. | ||
| rng |
Collaborator
There was a problem hiding this comment.
Sorry, why are we mentioning torch here?
Member
Author
There was a problem hiding this comment.
We had it in Loader thinking user might set torch seed and expect reprod. but I guess there is no need here in io.py
ilan-gold
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #135 kinda. This was we can reproduce results of the shuffler