feat: Introduce plan/trainer config objects with merge helpers. (#2904) #3666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sprengmeister-dev
force-pushed
the
2904-explicit-configs
branch
6 times, most recently
from
31ef322 to
432efa3
Compare
Sprengmeister-dev
force-pushed
the
2904-explicit-configs
branch
from
63ae571 to
03bd8c5
Compare
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3666 +/- ##
==========================================
+ Coverage 84.70% 86.22% +1.51%
==========================================
Files 225 226 +1
Lines 21637 21859 +222
==========================================
+ Hits 18327 18847 +520
+ Misses 3310 3012 -298
🚀 New features to boost your workflow:
|
ori-kron-wis
added
autotune
hub
private tests
Collaborator
|
close #2904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces explicit training configuration objects for scvi-tools, reducing reliance on loose kwargs and improving clarity across training APIs.
Changes
TrainingPlanConfig,TrainerConfig, and related config dataclasses with a shared merge helper.plan_config/trainer_configthrough training mixins, TrainRunner, and model training wrappers.Testing
python -m pytest tests/train/test_trainingplans.pypython -m pytest tests/train/test_config.pyNotes
plan_kwargsand**trainer_kwargsremain supported; explicit configs are additive.