Skip to content

Add container naming convention for challenges #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: bl4ze/dev
Choose a base branch
from
Open

Add container naming convention for challenges #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/manager/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ func deployChallenge(challenge *database.Challenge, config cfg.BeastChallengeCon
MountsMap: staticMount,
ImageId: challenge.ImageId,
ContainerName: coreUtils.EncodeID(config.Challenge.Metadata.Name),
ChallengeName: config.Challenge.Metadata.Name,
ContainerEnv: containerEnv,
ContainerNetwork: containerNetwork,
Traffic: config.Challenge.Env.TrafficType(),
Expand Down
3 changes: 2 additions & 1 deletion pkg/cr/containers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ type CreateContainerConfig struct {
MountsMap map[string]string
ImageId string
ContainerName string
ChallengeName string
ContainerEnv []string
ContainerNetwork string
Traffic TrafficType
Expand Down Expand Up @@ -141,7 +142,7 @@ func StopAndRemoveContainer(containerId string) error {
}

func CreateContainerFromImage(containerConfig *CreateContainerConfig) (string, error) {
containerName := containerConfig.ContainerName
containerName := fmt.Sprintf("beast_%s_%s", containerConfig.ChallengeName, containerConfig.ContainerName[:3])
Copy link
Contributor

@v1bh475u v1bh475u Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also incorporate the name of competition. Thoughts?

Copy link
Author

@peopleig peopleig Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it could be added in the struct and replace beast with comp. name in the container name
But are we taking competition name input anywhere? I didn't see it while running example challs

ctx := context.Background()
cli, err := client.NewEnvClient()
if err != nil {
Expand Down