Open
Conversation
oda
reviewed
Oct 6, 2024
| int maxAmount = 0; | ||
| for (int i = 0; i < amountCache.length; i++) { | ||
| if (i == 2) { | ||
| amountCache[i] += amountCache[i - 2]; |
There was a problem hiding this comment.
個人的には nums をコピーして amountCache にして、+= すると、amountCache の意味がループを回っている間に変わっていくので0で初期化して、構築していったほうが読みやすいと思います。
Ryotaro25
reviewed
Oct 6, 2024
| for (int i = 0; i < amountCache.length; i++) { | ||
| if (i == 2) { | ||
| amountCache[i] += amountCache[i - 2]; | ||
| } else if (2 < i) { |
|
最適化されたボトムアップとトップダウンどちらも試されていて全体的にいいと思いました。 |
| int[] amountCache = Arrays.copyOfRange(nums, 0, nums.length); | ||
| int maxAmount = 0; | ||
| for (int i = 0; i < amountCache.length; i++) { | ||
| if (i == 2) { |
There was a problem hiding this comment.
2がマジックナンバー化してるので、コメントがあると上から読んだとき理解しやすいと思います。
| return 0; | ||
| } | ||
|
|
||
| int twoBackMaxCount = 0, oneBackMaxCount = 0; |
There was a problem hiding this comment.
twoBackMaxAmount でいいのかなと思ったのですが、twoBackMaxCount と使い分けている理由って何でしょうか？
Owner
Author
There was a problem hiding this comment.
@goto-untrapped
返信が大変遅くなりました。
特に意図があって使い分けてるわけではありませんでした。問題文にも "return the maximum amount of money ~" とあるので、amount の方がいいですね。修正して step 4 に記載しました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/house-robber/description/