Open
Conversation
added 2 commits
October 8, 2024 07:25
nodchip
reviewed
Oct 8, 2024
|
|
||
| int maxProfit = 0; | ||
| for (int i = 0; i < prices.length - 1; i++) { | ||
| int profit = prices[i + 1] - prices[i]; |
There was a problem hiding this comment.
maxprofit += Math.max(0, prices[i + 1] - prices[i]); とも書けるのですが、かえって分かりにくくなっているかもしれません。
Owner
Author
There was a problem hiding this comment.
@nodchip
返信が大変おそくなりました。
そうですね、prices[i + 1] - prices[i] が profit であるというのは変数にするなりして示しておいてほしい気持ちはあります。行数は増えますがこのような形で:
int profit = prices[i + 1] - prices[i];
maxProfit += Math.max(0, profit);
|
|
||
| ## Step 2 | ||
|
|
||
| 株を保有している、していない状態それぞれの最大利益を算出していく方法。自分では思いつかなかった。 |
There was a problem hiding this comment.
自分もこれは思いつかなかったです。
holdingStockProfitが負の値からスタートするのが直感的ではなく
もっと前から株の売買をしていて、問題設定の日からスタートと考えれば自然なんですが
There was a problem hiding this comment.
holdingStockのためには株を買わなくてはならないので必ずマイナススタートになるのは良いのですが、これがprofitなのかというとなんか引っかかるので、PL（Profit & Loss）とかがいいんでしょうか。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/best-time-to-buy-and-sell-stock-ii/description/