-
Notifications
You must be signed in to change notification settings - Fork 26
abb/ssc600: add support for protection communication port #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
TODO:
|
|
It was not clear to me if the protection interface replaces the process bus interface, or if it is another interface. The ABB SSC600 documentation: https://techdoc.relays.protection-control.abb/r/SSC600-and-SSC600-SW-Engineering-Manual/1.5/en-US/VM-configuration |
4f052b1 to
048cb9e
Compare
3b68e57 to
44cdd20
Compare
eroussy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you upload the schema in svg ?
It will allow to modify it later if we need.
The rest seems good to me
The schema sources are exported as PNG metadata. |
eroussy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validate, but please wait for ABB test before merging that.
|
@dupremathieu Please be aware that during our tests we've figured out that there's some discrepancy between what's in the inventory and in the template regarding the PCI passthrough interface. ansible/templates/vm/ssc600.xml.j2 Line 104 in 4ccd29d
protection_port vs protection_ports
And there's another typo in ansible/templates/vm/ssc600.xml.j2 Line 108 in 4ccd29d
where it says protection_portci.
It should ideally be decided if the plural or singular form should be used and ensure that all used variables have the same name. |
1f18688 to
bd6fd0b
Compare
The 1.5 release of the ABB SSC600 template adds support for the protection communication port. This is a PCI passthrough interface that allows the VM to communicate with the protection devices. Update the template to include the protection communication port and update the example inventory file to include the new configuration. Also update the process_bus_interfaces to be pci_passthrough as requested by ABB. The 1.5.1 release of ABB SSC600 requires at least two management interfaces to work properly. Add a second management interface on br0. Also remove the xml encoding to prepare switching to debian13. Signed-off-by: Mathieu Dupré <mathieu.dupre@savoirfairelinux.com> Signed-off-by: Erwann Roussy <erwann.roussy@savoirfairelinux.com>
| upload_files: # This file is given with the ssc600 sw package | ||
| - src: '../files/qemu.hook' | ||
| dest: '/etc/libvirt/hooks/' | ||
| mode: "0744" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it is still needed. It's for MacVTap only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question, I will look into it with ABB R&D team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's for MacVTap only, and if you don't use it, you don't need the hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can describe the interface inside the VM:
- "Rear"
- "Process bus"
- "Protection communication"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer have MacVTap, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
I need to clarify that.
The 1.5 release of the ABB SSC600 template adds support for the protection communication port. This is a PCI passthrough interface that allows the VM to communicate with the protection devices.
Update the template to include the protection communication port and update the example inventory file to include the new configuration.