Merged
Conversation
- split monolithic src/ into focused crates: - glimpse-core: types, config, tokenizer, source detection - glimpse-fetch: git clone and url processing - glimpse-tui: file picker - glimpse (cli): binary, arg parsing, analyzer, output - migrate analyzer tests (16 tests for pattern matching, excludes, includes) - add AGENTS.md with development guidelines - clean dependency graph with core as shared foundation
- remove crates/ directory, consolidate into src/ - core, fetch, tui, code become submodules of the library - single Cargo.toml with all dependencies - remove BackwardsCompatOutputFormat, use serde rename_all - update imports: binary uses glimpse::, lib uses super::
- remove resolve.rs entirely (was doing O(files × calls) filesystem walks) - simplify CallGraph::build to use index-only O(1) lookups - add depth-limited traversal (default depth=1) - remove debug logging from code subcommand result: 23s → 24ms (~1000x faster)
- add Resolver with prioritized resolution: same-file → imports → global fallback - capture call qualifiers in tree-sitter queries for future type-aware resolution - add --strict flag to disable global name matching (reduces false positives) - global fallback enabled by default for broader coverage
- add LspClient for LSP server communication (stdin/stdout JSON-RPC) - add LspResolver for go-to-definition based call resolution - support auto-download for rust-analyzer and clangd binaries - support npm package installation (bun/npm) for pyright, tsserver - support go install for gopls with GOBIN set to lsp directory - install all LSP binaries locally in ~/.local/share/glimpse/lsp/ - add --precise flag to use LSP mode instead of heuristic resolution - add CallGraph::build_precise() integrating LSP with fallback - add comprehensive integration tests for all supported languages - update registry.toml with lsp configs (npm_package, go_package)
|
where's ur pr description sir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.