Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors multiple service imports across the backend and frontend codebases to use new native API functions for data retrieval and management while updating a backend method to exclude the current balance from user export.
- Updated the backend createMany method in the accounts service to remove the current balance field
- Replaced legacy service calls with native API functions (e.g., getAccountById, getIncomeById, getExpenseById, etc.) across various frontend routes and containers
- Modified several service import paths to use the new api-service module instead of legacy ssr/api files
Reviewed Changes
Copilot reviewed 102 out of 102 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/backend/src/modules/accounts/accounts.service.ts | Updated createMany method to remove current balance in user export |
| packages/frontend/app/(application)/transactions/incomes/[incomeId]/page.tsx | Replaced IncomeService with getIncomeById |
| packages/frontend/app/(application)/transactions/expenses/[expenseId]/page.tsx | Replaced ExpenseService with getExpenseById |
| packages/frontend/app/(application)/transactions/incomes/[incomeId]/edit/page.tsx | Replaced IncomeService with getIncomeById |
| packages/frontend/app/(application)/transactions/expenses/[expenseId]/edit/page.tsx | Replaced ExpenseService with getExpenseById |
| packages/frontend/app/(application)/categories/[categoryId]/edit/page.tsx | Replaced CategoryService with getCategoryById |
| packages/frontend/app/(application)/accounts/[accountId]/page.tsx | Replaced AccountService with getAccountById |
| packages/frontend/app/(application)/accounts/[accountId]/edit/page.tsx | Replaced AccountService with getAccountById |
| packages/frontend/app/(application)/categories/[categoryId]/page.tsx | Replaced CategoryService with getCategoryNameById |
| packages/frontend/app/(application)/transactions/transfers/[transferId]/edit/page.tsx | Replaced TransferService with getTransferById |
| packages/frontend/app/(application)/transactions/transfers/[transferId]/page.tsx | Replaced TransferService with getTransferById |
| packages/frontend/containers/accounts/AccountEditContainer.tsx | Replaced AccountService with getAccountById |
| packages/frontend/app/(application)/templates/[templateId]/edit/page.tsx | Replaced TransactionTemplateService with getTransactionTemplateById |
| packages/frontend/app/privacy-policy/page.tsx | Replaced AuthenticationService with getAuthenticationStatus |
| packages/frontend/containers/DashboardContainer.tsx | Replaced AccountService.getAll with getAllAccounts |
| packages/frontend/app/api/revalidate-cache/route.ts | Updated revalidateFullAppCache import path |
| packages/frontend/app/issues-with-login/page.tsx | Replaced AuthenticationService with getAuthenticationStatus |
| packages/frontend/app/layout.tsx | Updated AuthenticationService and UserService calls with native API functions |
| packages/frontend/containers/accounts/AccountContainer.tsx | Replaced multiple AccountService and UserPreferenceService calls with new API functions |
| packages/frontend/containers/accounts/AccountListingContainer.tsx | Replaced AccountService.getAll with getAllAccounts |
Comments suppressed due to low confidence (1)
packages/backend/src/modules/accounts/accounts.service.ts:50
- Setting 'currentDateBalance' to undefined may not remove the property from the exported user data. Consider omitting the property entirely or filtering it out before export to avoid potential serialization issues.
currentDateBalance: undefined,
5766b9f to
3b7f7fe
Compare
3b7f7fe to
57ccad7
Compare
There was a problem hiding this comment.
Copilot reviewed 24 out of 28 changed files in this pull request and generated no comments.
Files not reviewed (4)
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- packages/frontend/package.json: Language not supported
- packages/frontend/src/assets/tailwind.css: Language not supported
Comments suppressed due to low confidence (2)
packages/frontend/src/components/elements/Link.tsx:88
- Please add test coverage to verify that native view transitions operate as expected after removing the custom transition handling.
// TODO we should test if VT works as with native link
packages/frontend/app/(application)/transactions/[id]/page.tsx:43
- [nitpick] The function generateTransactionViewTransitionName returns an object and its 'description' property is used as the title view transition name. Consider renaming the property or the function's return field to 'titleVtName' for consistency and clarity.
titleVtName={generateTransactionViewTransitionName(transaction.id).description}
57ccad7 to
6a9b633
Compare
|
|
|
|





Describe your changes
Issue ticket number and link
Checklist before requesting a review
This pull request includes several changes to the backend and frontend codebases, focusing on updating service imports and modifying methods related to account and category management. The most important changes are listed below:
Backend Changes:
packages/backend/src/modules/accounts/accounts.service.ts: Updated thecreateManymethod to exclude the current balance from user export by settingcurrentDateBalancetoundefined.Frontend Changes:
Account Management:
packages/frontend/app/(application)/accounts/[accountId]/edit/page.tsx: ReplacedAccountService.getByIdwithgetAccountById. (packages/frontend/app/(application)/accounts/[accountId]/edit/page.tsxR3-L5, packages/frontend/app/(application)/accounts/[accountId]/edit/page.tsxL16-R15)packages/frontend/app/(application)/accounts/[accountId]/page.tsx: ReplacedAccountService.getByIdwithgetAccountById. (packages/frontend/app/(application)/accounts/[accountId]/page.tsxR3-L5, packages/frontend/app/(application)/accounts/[accountId]/page.tsxL18-R17)Category Management:
packages/frontend/app/(application)/categories/[categoryId]/edit/page.tsx: ReplacedCategoryService.getByIdwithgetCategoryById. (packages/frontend/app/(application)/categories/[categoryId]/edit/page.tsxR3-L5, packages/frontend/app/(application)/categories/[categoryId]/edit/page.tsxL16-R15)packages/frontend/app/(application)/categories/[categoryId]/page.tsx: ReplacedCategoryService.getByIdwithgetCategoryNameById. (packages/frontend/app/(application)/categories/[categoryId]/page.tsxR3-L5, packages/frontend/app/(application)/categories/[categoryId]/page.tsxL18-R20)General Service Imports:
ssr/apiservices with corresponding methods fromapi-service. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]