Skip to content

Feature/view transition#466

Merged
silte merged 5 commits intomainfrom
feature/view-transition
Apr 5, 2025
Merged

Feature/view transition#466
silte merged 5 commits intomainfrom
feature/view-transition

Conversation

@silte
Copy link
Collaborator

@silte silte commented Apr 5, 2025

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@silte silte requested a review from Copilot April 5, 2025 17:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/frontend/app/(application)/categories/page.tsx:125

  • Avoid shadowing the outer vtNames variable in the map function. Consider renaming this variable (e.g. to categoryVtNames) to improve clarity.
const vtNames = generateCategoryViewTransitionName(parentId!);

packages/frontend/src/components/UserMenu.tsx:192

  • Verify the arrow function syntax for the UserMenuItem component. Ensure that the function definition no longer contains any stray characters from the previous version.
> = ({ href, children, icon: Icon, onClick, vtName }) => {

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2025

Quality Gate Failed Quality Gate failed for 'Frontend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2025

@silte silte merged commit 1a29b51 into main Apr 5, 2025
32 of 33 checks passed
@silte silte deleted the feature/view-transition branch April 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant