Support P4.org In-band Network Telemetry (INT) #4230
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingfeihu
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4230 +/- ##
===========================================
- Coverage 81.77% 47.55% -34.22%
===========================================
Files 331 325 -6
Lines 76721 71527 -5194
===========================================
- Hits 62736 34016 -28720
- Misses 13985 37511 +23526
|
jingfeihu
force-pushed
the
master.hujf
branch
from
84a8dde to
48a8efd
Compare
1.support INT MX/MD mode. 2.support INT over IPv4/IPv6+TCP/UDP/VXLAN/GRE/GENEVE. 3.add 28 testcases for INT.
jingfeihu
force-pushed
the
master.hujf
branch
from
48a8efd to
5b44983
Compare
polybassa
reviewed
Jan 25, 2024
| else: | ||
| return self.sprintf("TCP %TCP.sport% > %TCP.dport% %TCP.flags%") | ||
|
|
||
| def guess_payload_class(self, payload): |
There was a problem hiding this comment.
I think its not a good idea to import your contrib layer in guess_payload_class of TCP. Can you maybe move this port to dispatch_hook?
polybassa
reviewed
Jan 25, 2024
| else: | ||
| return self.sprintf("UDP %UDP.sport% > %UDP.dport%") | ||
|
|
||
| def guess_payload_class(self, payload): |
|
Thanks for your PR. Your code looks good so far, besides my to comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.support INT MX/MD mode.
2.support INT over IPv4/IPv6+TCP/UDP/VXLAN/GRE/GENEVE.
3.add 28 testcases for INT.