Skip to content

Conversation

@Splinter1984
Copy link
Contributor

@Splinter1984 Splinter1984 commented Oct 1, 2024

This PR fix pl_len calculation issue for DataPacket of RTPS protocol.
Take into account the size of inlineQoS during payload length calculation.
Closes #4594

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.87%. Comparing base (ef72e1d) to head (1bb70c5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
+ Coverage   80.48%   80.87%   +0.38%     
==========================================
  Files         368      368              
  Lines       90255    90256       +1     
==========================================
+ Hits        72645    72992     +347     
+ Misses      17610    17264     -346     
Files with missing lines Coverage Δ
scapy/contrib/rtps/common_types.py 95.31% <100.00%> (+0.03%) ⬆️
scapy/contrib/rtps/rtps.py 100.00% <100.00%> (+1.17%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Splinter1984 Splinter1984 force-pushed the fix_data_packet_pl_len branch 2 times, most recently from d87ccc8 to 06aeab2 Compare October 10, 2024 14:28
@gpotter2 gpotter2 added the bug label May 30, 2025
Take into account size of `inlineQoS`.
@gpotter2 gpotter2 force-pushed the fix_data_packet_pl_len branch from 998851c to 1bb70c5 Compare November 2, 2025 22:38
@gpotter2 gpotter2 enabled auto-merge (squash) November 2, 2025 22:39
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
@gpotter2 gpotter2 merged commit dc266d5 into secdev:master Nov 2, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTPS DataPacketField wrong payload len.

2 participants