Fix BSD loading on 32bits#4669
Merged
gpotter2 merged 1 commit intosecdev:masterfrom Feb 22, 2025
gpotter2:bds-32bits
Merged
Conversation
Member
gpotter2
commented
Feb 22, 2025
- fixes OpenBSD 32-bit, ifaces not populated #4626 and add tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4669 +/- ##
==========================================
- Coverage 82.11% 81.33% -0.79%
==========================================
Files 359 359
Lines 86576 86576
==========================================
- Hits 71096 70415 -681
- Misses 15480 16161 +681
|
|
Many thanks, confirmed this fixes 32-bit and does not break 64-bit. |
Member
Author
|
You're welcome @sthen. Btw I tested sending on the loopback after seeing openbsd/src@473ed62, it seems to work just fine on 2.6.1 (but could indeed have been broken on 2.4.5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.