Skip to content

Conversation

@Ansariel
Copy link
Contributor

Fixes for XUI parser warnings:

  • LLFloaterMarketplace::postBuild calls parent method which already tries to find the webbrowser control with a different name and adds itself as observer
  • Incorrect attribute name "tooltip" in panel_preferences_move.xml

* LLFloaterMarketplace::postBuild calls parent method which already tries to find the webbrowser control with a different name and adds itself as observer
* Incorrect attribute name "tooltip" in panel_preferences_move.xml
@github-actions github-actions bot added the c/cpp label Oct 31, 2025
layout="topleft"
left="0"
name="marketplace_contents"
name="webbrowser"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two other places are also using marketplace_contents, in llviewermedia.cpp and llviewerwindow.cpp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was only one in llviewermedia.cpp - fixed that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry, it's there in develop, but was removed in 2025.08

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same problem is probably present in LLFloaterSearch::postBuild()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaaaand fixed those as well.

Question: Why is it everytime I open search I have to click the cookie banner thing away? This also happens on current release and is unrelated to these changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also happens on current release and is unrelated to these changes.

I think 2025.07 is removing cef's folder each launch or something like that. #4908

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also happens on current release and is unrelated to these changes.

I think 2025.07 is removing cef's folder each launch or something like that. #4908

But it also happens in release 7.2.1 - which AFAIK is 2025.06 - and before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think before 7.2.2 it was a problem with cef instances being locked from files by each other since they were sharing those files. Only one instance could use the files. In 7.2.2 they got individual directories for that. But I'm not entirely in the loop on the topic of cef, so I might be wrong.

@akleshchev
Copy link
Contributor

Thank you!

@akleshchev akleshchev linked an issue Nov 4, 2025 that may be closed by this pull request
@akleshchev akleshchev merged commit 5e11448 into secondlife:release/2025.08 Nov 4, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
@secondlife secondlife unlocked this conversation Nov 4, 2025
@Ansariel Ansariel deleted the 202508-xui-fixes branch November 4, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning about Making dummy class LLMediaCtrl

2 participants