chore(wrapper): various adjustments including potential fix for singleton deletion #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| declare -rx WAYLAND_DISPLAY="${WAYLAND_DISPLAY:-}" | ||
|
|
||
| # Exit immediately if run as root | ||
| if [ "$(id -u)" -eq 0 ]; then |
Contributor
There was a problem hiding this comment.
why was this moved?
Collaborator
Author
There was a problem hiding this comment.
Just so that it happens after variable sanitation.
Contributor
There was a problem hiding this comment.
@RKNF404 what's the benefit there though? shouldn't we exit ASAP?
Collaborator
Author
There was a problem hiding this comment.
Mainly to control PATH, but I guess it doesn't really matter here. We would still be exiting ASAP, no commands are executed so it makes no fundamental difference in that sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.