This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Add message callbacks #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
feature/add-message-callbacks
branch
from
9d61fc5 to
c0a5089
Compare
Author
|
@calvinfo Care to take a look? |
Contributor
|
@thehydroimpulse any issues with this? Seems reasonable. |
Contributor
promag
force-pushed
the
feature/add-message-callbacks
branch
from
c0a5089 to
49d452b
Compare
Author
|
@thehydroimpulse ping. |
doron2402
reviewed
Jan 12, 2017
| conn.on('ready', function(){ | ||
| conn.end(); | ||
| conn.publish(topic, 'stuff'); | ||
| conn.publish('test', 'stuff'); |
doron2402
reviewed
Jan 12, 2017
| var utils = require('../utils'); | ||
|
|
||
| beforeEach(function(done){ | ||
| utils.deleteTopic('test', done); |
|
Are you guys planing on merging this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional callbacks for
Message.finish,Message.requeueandMessage.touch.The image used in CircleCI must be Ubuntu 14.04 to be able to use
nsq@0.3.8.This PR also partially reverts the work done in #70. To fix the test suite we must ensure no reader is left at subscribe state before the tests end, otherwise the next test can fail because nsqd can deliver the message to the other reader.